Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753724AbbLJP5Z (ORCPT ); Thu, 10 Dec 2015 10:57:25 -0500 Received: from iolanthe.rowland.org ([192.131.102.54]:35438 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751399AbbLJP5Y (ORCPT ); Thu, 10 Dec 2015 10:57:24 -0500 Date: Thu, 10 Dec 2015 10:57:23 -0500 (EST) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Peter Senna Tschudin cc: "Geyslan G. Bem" , Greg Kroah-Hartman , , Subject: Re: [PATCH 6/9v2] usb: host: ehci.h: use space after comma In-Reply-To: <20151210101856.GF4013@toshiba-peter.rsr.lip6.fr> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 771 Lines: 19 On Thu, 10 Dec 2015, Peter Senna Tschudin wrote: > > /* next async queue entry, or pointer to interrupt/periodic QH */ > > -#define QH_NEXT(ehci,dma) (cpu_to_hc32(ehci, (((u32)dma)&~0x01f)|Q_TYPE_QH)) > > +#define QH_NEXT(ehci, dma) \ > > + (cpu_to_hc32(ehci, (((u32) dma) & ~0x01f) | Q_TYPE_QH)) > > For the maintainers: Is having two lines here better than having a line with 83 chars? Two lines is better. This patch is fine and so are the other 7 -- I never received 9/9v2 (the original 9/9 was okay). Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/