Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754451AbbLJQCS (ORCPT ); Thu, 10 Dec 2015 11:02:18 -0500 Received: from mail-vk0-f52.google.com ([209.85.213.52]:35408 "EHLO mail-vk0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751444AbbLJQCR (ORCPT ); Thu, 10 Dec 2015 11:02:17 -0500 MIME-Version: 1.0 In-Reply-To: References: <20151210101856.GF4013@toshiba-peter.rsr.lip6.fr> Date: Thu, 10 Dec 2015 13:02:16 -0300 Message-ID: Subject: Re: [PATCH 6/9v2] usb: host: ehci.h: use space after comma From: "Geyslan G. Bem" To: Alan Stern Cc: Peter Senna Tschudin , Greg Kroah-Hartman , linux-usb@vger.kernel.org, LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 995 Lines: 34 2015-12-10 12:57 GMT-03:00 Alan Stern : > On Thu, 10 Dec 2015, Peter Senna Tschudin wrote: > >> > /* next async queue entry, or pointer to interrupt/periodic QH */ >> > -#define QH_NEXT(ehci,dma) (cpu_to_hc32(ehci, (((u32)dma)&~0x01f)|Q_TYPE_QH)) >> > +#define QH_NEXT(ehci, dma) \ >> > + (cpu_to_hc32(ehci, (((u32) dma) & ~0x01f) | Q_TYPE_QH)) >> >> For the maintainers: Is having two lines here better than having a line with 83 chars? > > Two lines is better. This patch is fine and so are the other 7 -- I > never received 9/9v2 (the original 9/9 was okay). Alan, The 9 is v1 only, since it mentions the tool (coccinelle) correctly. Tks. > > Alan Stern > -- Regards, Geyslan G. Bem hackingbits.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/