Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755245AbbLJRfC (ORCPT ); Thu, 10 Dec 2015 12:35:02 -0500 Received: from smtp11.smtpout.orange.fr ([80.12.242.133]:19729 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754398AbbLJRe7 (ORCPT ); Thu, 10 Dec 2015 12:34:59 -0500 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Thu, 10 Dec 2015 18:34:57 +0100 X-ME-IP: 92.156.1.80 From: Robert Jarzmik To: Tomi Valkeinen Cc: Rob Herring , Jean-Christophe Plagniol-Villard , , Subject: Re: [PATCH v5 2/2] video: fbdev: pxafb: initial devicetree conversion References: <1447792337-13876-1-git-send-email-robert.jarzmik@free.fr> <1447792337-13876-2-git-send-email-robert.jarzmik@free.fr> <5665B3C1.1080005@ti.com> <87bna2kmp7.fsf@belgarion.home> <56699A57.9030209@ti.com> X-URL: http://belgarath.falguerolles.org/ Date: Thu, 10 Dec 2015 18:34:56 +0100 In-Reply-To: <56699A57.9030209@ti.com> (Tomi Valkeinen's message of "Thu, 10 Dec 2015 17:29:27 +0200") Message-ID: <874mfqjjgf.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1337 Lines: 33 Tomi Valkeinen writes: > On 07/12/15 22:50, Robert Jarzmik wrote: > >>> It seems that at least "depth" is missing from the binding document. >> You're right. >> >> Actually depth is not a "hardware" caracteristic. Moreover it's just used as an >> overlay for pxafb_set_pixfmt() to superseed var->bits_per_pixel. I'm wondering >> if the right path for of_get_pxafb_mode_info() would be to remove completely >> depth, and leave it initialized at 0 for the DT case. >> >> What do you think of this approach ? The other one would be to modify the >> binding, and yet I feel this depth doesn't belong to the binding, it's my patch >> which requires another spin IMHO. > > Yes, we should avoid non-hardware relate properties in the .dts files if > at all possible. If the driver works fine without the property, I think > it's fine to remove it. If it is required it needs to be added to the > binding document. Ok, agreed Tomi. That commits me for a v6, as the driver works fine on my tests. I'll send it in the next couple of days. Thanks for the review. -- Robert -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/