Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755438AbbLJSlD (ORCPT ); Thu, 10 Dec 2015 13:41:03 -0500 Received: from mail-ob0-f170.google.com ([209.85.214.170]:35370 "EHLO mail-ob0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755394AbbLJSk7 (ORCPT ); Thu, 10 Dec 2015 13:40:59 -0500 MIME-Version: 1.0 In-Reply-To: <20151210170853.GC16026@mail.corp.redhat.com> References: <1447345535-2912-1-git-send-email-simon@mungewell.org> <1447345535-2912-2-git-send-email-simon@mungewell.org> <20151119183106.GC24773@dtor-ws> <20151210170853.GC16026@mail.corp.redhat.com> Date: Thu, 10 Dec 2015 10:40:58 -0800 Message-ID: Subject: Re: [Patch-V2 1/6] INPUT: xpad: Add minimal support for Logitech G920 Wheel From: Dmitry Torokhov To: Benjamin Tissoires Cc: Jiri Kosina , Simon Wood , "linux-input@vger.kernel.org" , lkml , Edwin , =?UTF-8?B?TWljaGFsIE1hbMO9?= , elias vanderstuyft Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2864 Lines: 74 On Thu, Dec 10, 2015 at 9:08 AM, Benjamin Tissoires wrote: > On Dec 09 2015 or thereabouts, Dmitry Torokhov wrote: >> On Wed, Dec 9, 2015 at 5:23 PM, Dmitry Torokhov >> wrote: >> > On Thu, Nov 19, 2015 at 10:31 AM, Dmitry Torokhov >> > wrote: >> >> On Thu, Nov 19, 2015 at 02:50:51PM +0100, Jiri Kosina wrote: >> >>> On Thu, 12 Nov 2015, Simon Wood wrote: >> >>> >> >>> > When plugged in the Logitech G920 wheel starts with USBID 046d:c261 >> >>> > and behaviors as a vendor specific class. If a 'magic' byte sequence >> >>> > is sent the wheel will detach and reconnect as a HID device with the >> >>> > USBID 046d:c262. >> >>> > >> >>> > Signed-off-by: Simon Wood >> >>> >> >>> Adding Dmitry to CC. >> >>> >> >>> Dmitry, I am planning to take this through my tree together with the rest >> >>> of the actual HID support for that device if you Ack this. >> >> >> >> Hmm, I have an incoming series for xbox that night clash with this... If >> >> you'll put it in a clean branch off 4.3 I'd pull it and then get more >> >> changes on top. >> >> >> >> Can we also change the subject as it is not about adding a minimal >> >> support. Something like "Input: xpad - switch Logitech G920 Wheel into >> >> HID mode" >> >> >> >> Otherwise: >> >> >> >> Acked-by: Dmitry Torokhov >> > >> > Hmm, looking sat this some more why are we waiting to switch device >> > mode until after userspace opens input device instead of when we are >> > executing driver probe()? >> > >> >> Actually, thinking about it even more, why do we want to have this in >> xpad.c? Have HID module handle both IDs and switch to HID mode if we >> want HID to handle this device. I think we should revert/drop this >> patch. >> > > Hi Dmitry, Hi Benjamin, > > IIRC, last time I saw an XBox-like controller, it doesn't register as a > HID device at all. SO I think It will be hard to switch it into the HID > mode from HID directly. > Simon, can you confirm that the device does not contains any references > to HID while in the XBox mode (lsusb -v should give enough information). > > Switching the device during probe in xpad.c makes a lot of sense > however. It makes as much sense doing it in xpad as doing it from a random USB network driver. I mean the only reason we are doing it from xpad is because of name and the fat that it has usb_driver structure. Nobody stops you from creating a tiny USB stub driver in hid portion that would probe the "non-hid" device and switch it over to hid. Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/