Subject: Re: [PATCH 01/13] irq_poll: make blk-iopoll available outside the
 block layer
To: Christoph Hellwig <hch@lst.de>, <linux-rdma@vger.kernel.org>
References: <1449521512-22921-1-git-send-email-hch@lst.de>
 <1449521512-22921-2-git-send-email-hch@lst.de>
CC: <sagig@dev.mellanox.co.il>, <bart.vanassche@sandisk.com>, <axboe@fb.com>,
        <linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>
From: Bart Van Assche <bart.vanassche@sandisk.com>
Message-ID: <5669C765.8030109@sandisk.com>
Date: Thu, 10 Dec 2015 10:41:41 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: <1449521512-22921-2-git-send-email-hch@lst.de>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
SpamDiagnosticOutput: 1:23
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Dec 2015 18:41:42.4014
 (UTC)
X-MS-Exchange-CrossTenant-Id: fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d;Ip=[63.163.107.173];Helo=[milsmgep12.sandisk.com]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL2PR02MB290
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 645
Lines: 22

On 12/07/2015 12:51 PM, Christoph Hellwig wrote:
> -enum {
> -	IOPOLL_F_SCHED		= 0,
> -	IOPOLL_F_DISABLE	= 1,
> -};

[ ... ]

> +enum {
> +	IRQ_POLL_F_SCHED		= 0,
> +	IRQ_POLL_F_DISABLE	= 1,
> +};

A nitpick: the values of these constants were aligned in the original 
code but no longer in the new code. Whether or not this gets addressed:

Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/