Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754206AbbLJS5x (ORCPT ); Thu, 10 Dec 2015 13:57:53 -0500 Received: from mail.kernel.org ([198.145.29.136]:44697 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752599AbbLJS5v (ORCPT ); Thu, 10 Dec 2015 13:57:51 -0500 Date: Thu, 10 Dec 2015 15:57:43 -0300 From: Arnaldo Carvalho de Melo To: =?utf-8?B?5bmz5p2+6ZuF5bezIC8gSElSQU1BVFXvvIxNQVNBTUk=?= Cc: "'Namhyung Kim'" , Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML , David Ahern , Frederic Weisbecker , Andi Kleen , Stephane Eranian , Adrian Hunter Subject: Re: [PATCH/RFC 01/16] perf top: Delete half-processed hist entries when exit Message-ID: <20151210185743.GH17996@kernel.org> References: <1449734015-9148-1-git-send-email-namhyung@kernel.org> <1449734015-9148-2-git-send-email-namhyung@kernel.org> <50399556C9727B4D88A595C8584AAB375264F907@GSjpTKYDCembx32.service.hitachi.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <50399556C9727B4D88A595C8584AAB375264F907@GSjpTKYDCembx32.service.hitachi.net> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1116 Lines: 25 Em Thu, Dec 10, 2015 at 09:55:44AM +0000, 平松雅巳 / HIRAMATU，MASAMI escreveu: > >From: Namhyung Kim [mailto:namhyung@kernel.org] > > > >After sample processing is done, hist entries are in both of > >hists->entries and hists->entries_in (or hists->entries_collapsed). > >So I guess perf report does not have leaks on hists. > > > >But for perf top, it's possible to have half-processed entries which > >are only in hists->entries_in. Eventually they will go to the > >hists->entries and get freed but they cannot be deleted by current > >hists__delete_entries(). This patch adds hists__delete_all_entries > >function to delete those entries. > > > > This is tested under the refcnt debugger and I've reviewed it. > > Acked-by: Masami Hiramatsu > Tested-by: Masami Hiramatsu Thanks, applied. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/