Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751956AbbLJTKV (ORCPT ); Thu, 10 Dec 2015 14:10:21 -0500 Received: from mail-qg0-f45.google.com ([209.85.192.45]:34446 "EHLO mail-qg0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751239AbbLJTKS (ORCPT ); Thu, 10 Dec 2015 14:10:18 -0500 MIME-Version: 1.0 In-Reply-To: References: <1449584716-21093-1-git-send-email-linux@rasmusvillemoes.dk> Date: Thu, 10 Dec 2015 21:10:17 +0200 Message-ID: Subject: Re: [PATCH] [SCSI] osd: fix signed char versus %02x issue From: Andy Shevchenko To: "Martin K. Petersen" Cc: Rasmus Villemoes , Boaz Harrosh , Benny Halevy , "James E.J. Bottomley" , osd-dev@open-osd.org, linux-scsi , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1168 Lines: 28 On Thu, Dec 10, 2015 at 8:15 PM, Martin K. Petersen wrote: >>>>>> "Rasmus" == Rasmus Villemoes writes: > > Rasmus> If char is signed and one of these bytes happen to have a value > Rasmus> outside the ascii range, the corresponding output will consist > Rasmus> of "ffffff" followed by the two hex chars that were actually > Rasmus> intended. One way to fix it would be to change the casts to > Rasmus> (u8*) aka (unsigned char*), but it is much simpler (and > Rasmus> generates smaller code) to use the %ph extension which was > Rasmus> created for such short hexdumps. > > Applied to 4.5/scsi-queue. How fast! Martin, I have several patches on SCSI subsytem like this one. Some of them didn't manage kernel (even having Ack!) for years already. Is it okay if I collect them together and send a bunch once again Cc'ing you? -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/