Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752002AbbLJUwh (ORCPT ); Thu, 10 Dec 2015 15:52:37 -0500 Received: from dd1012.kasserver.com ([85.13.128.8]:54974 "EHLO dd1012.kasserver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751032AbbLJUwf (ORCPT ); Thu, 10 Dec 2015 15:52:35 -0500 Date: Thu, 10 Dec 2015 21:52:27 +0100 From: Danny Milosavljevic To: Maxime Ripard Cc: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Chen-Yu Tsai , alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5] sun4i-codec: add inputs Message-ID: <20151210215227.6453acc8@dayas> In-Reply-To: <20151210175420.GH27957@lukather> References: <20151208042013.11d31f09@dayas> <20151210175420.GH27957@lukather> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.27; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1651 Lines: 48 Hi Maxime, On Thu, 10 Dec 2015 18:54:20 +0100 Maxime Ripard wrote: > > + SOC_DAPM_SINGLE("Mic1-In Playback Switch", SUN4I_CODEC_DAC_ACTL, > > + SUN4I_CODEC_DAC_ACTL_MIC1RS, 1, 0), > > + SOC_DAPM_SINGLE("Mic2-In Playback Switch", SUN4I_CODEC_DAC_ACTL, > > + SUN4I_CODEC_DAC_ACTL_MIC2RS, 1, 0), > > }; > > Do we need the -In part of FM, Mic1 and Mic2? For consistency to what's in linux-sunxi.git, I will remove the "-In" from the Mic names in v7. For FM, do we? I don't know. Are there ALSA devices which output to FM? > Mic1 is already defined a few lines above. > And you have the Mixers routes a bit above too. Aha, Mic1 is there in branch "sunxi-next". In branch "sunxi/for-next", it's not there. This patch is for the latter. I'm currently rebasing on the former, but it will take some time. The differences between these driver versions are: - Mic1 Preamplifier is registered as PGA instead of switch in the former. - Mic1 is already an input in the former. - VMIC is handled in the former. - ADC Capturing support exists in the former. That's it. I'll retest a patch based on the former... > [global mutation] > We'll need to fix that, see the other discussion. Yeah, I think I found a nicer way to do it in v6. Thanks, Danny -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/