MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.11.1512102050290.3623@nanos>
References: <CAO6TR8W1ViJonskb0eObG+THObpabh909ob0Oz_8LAvNMuOPmA@mail.gmail.com>
	<alpine.DEB.2.11.1512101942470.3623@nanos>
	<CALCETrUaWxqyuyE2FqCs0ULPBdKMwCPtaoneyt4yBA8r5a5=yQ@mail.gmail.com>
	<alpine.DEB.2.11.1512102050290.3623@nanos>
Date: Thu, 10 Dec 2015 15:26:43 -0700
Message-ID: <CAO6TR8VW4P9KWwh_X4ckD_pCi+hkfKZ4mPAqquv6cJAm-HAy9g@mail.gmail.com>
Subject: Re: [PATCH 1/1] Fix int1 recursion when no perf_bp_event is registeredy
From: Jeff Merkey <linux.mdb@gmail.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Andy Lutomirski <luto@amacapital.net>, LKML <linux-kernel@vger.kernel.org>,
        Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
        X86 ML <x86@kernel.org>, Peter Zijlstra <peterz@infradead.org>,
        Andy Lutomirski <luto@kernel.org>,
        Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
        Steven Rostedt <rostedt@goodmis.org>, Borislav Petkov <bp@alien8.de>,
        Jiri Olsa <jolsa@kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1324
Lines: 35

I'll submit a second patch later this evening with a graceful message
when this happens.  I need to look over this code path -- its in a
very mature section of code and detecting this condition (bp not being
present) may break other code paths and subsystems ifs not done very
carefully.  The current dr7 check works and I have tested this code,
but does not print a message.


On 12/10/15, Thomas Gleixner <tglx@linutronix.de> wrote:
> On Thu, 10 Dec 2015, Andy Lutomirski wrote:
>> On brief inspection, this smells like a microcode bug.  Can you send
>> /proc/cpuinfo output?
>>
>> If this is the issue, I'm not sure we want to be in the business of
>> working around localized microcode bugs and, if we do, then I think we
>> should explicitly detect the bug and log about it.
>
> I think we should handle such stuff gracefully. Yes, we should log it
> and we also should check what the contents of the debug registers are.
>
> If dr7 has a break point enabled w/o perf having one installed then we
> know that someone did a horrible hackery ....
>
> Thanks,
>
> 	tglx
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/