Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752451AbbLJXiP (ORCPT ); Thu, 10 Dec 2015 18:38:15 -0500 Received: from kvm5.telegraphics.com.au ([98.124.60.144]:44005 "EHLO kvm5.telegraphics.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751172AbbLJXiM (ORCPT ); Thu, 10 Dec 2015 18:38:12 -0500 Date: Fri, 11 Dec 2015 10:38:02 +1100 (AEDT) From: Finn Thain To: Ondrej Zary cc: Michael Schmitz , linux-m68k@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 78/71] ncr5380: Add support for HP 53C400A-based cards (C2502) In-Reply-To: <201512091233.36721.linux@rainbow-software.org> Message-ID: References: <20151118083455.331768508@telegraphics.com.au> <1449561099-9981-1-git-send-email-linux@rainbow-software.org> <201512091233.36721.linux@rainbow-software.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1360 Lines: 40 On Wed, 9 Dec 2015, Ondrej Zary wrote: > > > @@ -743,6 +786,7 @@ module_param(ncr_5380, int, 0); > > > module_param(ncr_53c400, int, 0); > > > module_param(ncr_53c400a, int, 0); > > > module_param(dtc_3181e, int, 0); > > > +module_param(hp_53c400a, int, 0); > > > > Any reason you did not add the corresponding __setup option? > > I wonder if __setup is really required. I thought that it should go away > and module parameters used instead. Yes, after re-reading the header files I see that you are right. > > > Did you consider re-using the existing ncr_53c400a option (for port & > > irq settings) and adding a new setup option and module param for card > > magic? > > Looks like a good idea. What I had in mind was an 'ncr_magic' option, to go with 'ncr_irq' and 'ncr_addr'. This is supposed to be a generic driver, after all. But now that I've seen what that would involve (adding another member to struct override) I've changed my mind. I think the new board type was the right approach. That is, a combination of your v2 and v3 patches. I'll send my version to you to test. Thanks. -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/