Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752970AbbLKByR (ORCPT ); Thu, 10 Dec 2015 20:54:17 -0500 Received: from szxga03-in.huawei.com ([119.145.14.66]:55412 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751517AbbLKByQ (ORCPT ); Thu, 10 Dec 2015 20:54:16 -0500 Message-ID: <566A2CA0.8070608@huawei.com> Date: Fri, 11 Dec 2015 09:53:36 +0800 From: "Wangnan (F)" User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: "'Arnaldo Carvalho de Melo'" CC: =?UTF-8?B?5bmz5p2+6ZuF5bezIC8gSElSQU1BVFXvvIxNQVNBTUk=?= , Peter Zijlstra , Adrian Hunter , "linux-kernel@vger.kernel.org" , "linux-perf-users@vger.kernel.org" , Ingo Molnar , "Namhyung Kim" , Jiri Olsa , Alexei Starovoitov Subject: Re: [PATCH perf/core 00/22] perf refcnt debugger API and fixes References: <20151209021047.10245.8918.stgit@localhost.localdomain> <20151209134138.GB15864@kernel.org> <50399556C9727B4D88A595C8584AAB375264FB48@GSjpTKYDCembx32.service.hitachi.net> <56697572.90701@huawei.com> <20151210151239.GB17996@kernel.org> In-Reply-To: <20151210151239.GB17996@kernel.org> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.111.66.109] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020204.566A2CB2.00BD,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-05-26 15:14:31, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 112e8d6064fc1ee5cf15ae6036058281 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1437 Lines: 41 On 2015/12/10 23:12, 'Arnaldo Carvalho de Melo' wrote: [SNIP] > But this requires having these special refcnt__ routines, that will make > tools/perf/ code patterns for reference counts look different that the > refcount patterns in the kernel :-\ > > And would be a requirement to change the observed workload :-\ > > Is this _strictly_ required? No. The requirement should be: 1. The create/get/put/delete functions are non-inline (because dwarf info is not as reliable as symbol); 2. From their argument list, we can always get the variable we need (the pointer of objects, the value of refcnt, etc.) We don't have to use this refcnt things. > Can't we, for a project like perf, where we > know where some refcount (say, the one for 'struct thread') gets > initialized, use that (thread__new()) and then hook into thread__get and > thread__put and then use the destructor, thread__delete() as the place > to dump leaks? > I think it is possible. If we can abstract a common pattern about it, we can provide a perf subcommand which we can deal with generic alloc/free pattern. I'll put it on my todo-list. Currently we are focusing on perf daemonization. Thank you. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/