Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752507AbbLKCfy (ORCPT ); Thu, 10 Dec 2015 21:35:54 -0500 Received: from mail.kernel.org ([198.145.29.136]:38341 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751499AbbLKCfw (ORCPT ); Thu, 10 Dec 2015 21:35:52 -0500 MIME-Version: 1.0 In-Reply-To: <1449796126-14906-1-git-send-email-bjorn.andersson@sonymobile.com> References: <1449796126-14906-1-git-send-email-bjorn.andersson@sonymobile.com> From: Rob Herring Date: Thu, 10 Dec 2015 20:35:28 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] serial: earlycon: Initialize uart_port spinlock To: Bjorn Andersson , Greg Kroah-Hartman Cc: Jiri Slaby , "linux-serial@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1600 Lines: 46 On Thu, Dec 10, 2015 at 7:08 PM, Bjorn Andersson wrote: > Initialize the uart_port spinlock of earlycon to avoid the BUG() when > booting with spinlock debug enabled. > > Signed-off-by: Bjorn Andersson Same patch[1] should already be in Greg's queue. Rob [1] https://lkml.org/lkml/2015/11/27/165 > --- > drivers/tty/serial/earlycon.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/tty/serial/earlycon.c b/drivers/tty/serial/earlycon.c > index f09636083426..6c18891ad8d0 100644 > --- a/drivers/tty/serial/earlycon.c > +++ b/drivers/tty/serial/earlycon.c > @@ -111,6 +111,8 @@ static int __init register_earlycon(char *buf, const struct earlycon_id *match) > int err; > struct uart_port *port = &early_console_dev.port; > > + spin_lock_init(&port->lock); > + > /* On parsing error, pass the options buf to the setup function */ > if (buf && !parse_options(&early_console_dev, buf)) > buf = NULL; > @@ -202,6 +204,7 @@ int __init of_setup_earlycon(unsigned long addr, > int err; > struct uart_port *port = &early_console_dev.port; > > + spin_lock_init(&port->lock); > port->iotype = UPIO_MEM; > port->mapbase = addr; > port->uartclk = BASE_BAUD * 16; > -- > 2.4.2 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/