Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752811AbbLKGv2 (ORCPT ); Fri, 11 Dec 2015 01:51:28 -0500 Received: from mail-pf0-f176.google.com ([209.85.192.176]:34748 "EHLO mail-pf0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751618AbbLKGv1 (ORCPT ); Fri, 11 Dec 2015 01:51:27 -0500 Date: Fri, 11 Dec 2015 12:21:22 +0530 From: Sudip Mukherjee To: Jandy Gou Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, rickard_strandqvist@spectrumdigital.se, linux-kernel@vger.kernel.org, cristina.opriceana@gmail.com Subject: Re: [PATCH] Staging:rtl8192u: fixes the following sparse warning: Message-ID: <20151211065122.GC4763@sudip-pc> References: <1449813131-25459-1-git-send-email-qingsong.gou@ck-telecom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1449813131-25459-1-git-send-email-qingsong.gou@ck-telecom.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1450 Lines: 32 On Fri, Dec 11, 2015 at 01:52:11PM +0800, Jandy Gou wrote: > drivers/staging/rtl8192u/r8192U_core.c:3212:6: warning: symbol > 'rtl819x_watchdog_wqcallback' was not declared. Should it be static? > drivers/staging/rtl8192u/r8192U_core.c:3276:6: warning: symbol > 'watch_dog_timer_callback' was not declared. Should it be static? > drivers/staging/rtl8192u/r8192U_core.c:3282:5: warning: symbol > '_rtl8192_up' was not declared. Should it be static? > drivers/staging/rtl8192u/r8192U_core.c:3333:5: warning: symbol > 'rtl8192_close' was not declared. Should it be static? > drivers/staging/rtl8192u/r8192U_core.c:3406:6: warning: symbol > 'rtl8192_restart' was not declared. Should it be static? > drivers/staging/rtl8192u/r8192U_core.c:4618:6: warning: symbol > 'rtl8192_irq_rx_tasklet' was not declared. Should it be static? > drivers/staging/rtl8192u/r8192U_core.c:4736:6: warning: symbol > 'rtl8192_cancel_deferred_work' was not declared. Should it be static? > > Signed-off-by: Jandy Gou > --- This has already been done by commit: bdc01d5711b3 ("staging: rtl8192u: Make core functions static") And the commit date shows April. Which tree are you using? regards sudip -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/