From: Dexuan Cui <decui@microsoft.com>
To: KY Srinivasan <kys@microsoft.com>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
        "olaf@aepfle.de" <olaf@aepfle.de>,
        "apw@canonical.com" <apw@canonical.com>,
        "vkuznets@redhat.com" <vkuznets@redhat.com>,
        "jasowang@redhat.com" <jasowang@redhat.com>
Subject: RE: [PATCH V2 02/10] Drivers: hv: utils: run polling callback always
 in interrupt context
Thread-Topic: [PATCH V2 02/10] Drivers: hv: utils: run polling callback always
 in interrupt context
Thread-Index: AQHREqN/B3uPQ5hvd0CAAnuI1+1NHp7EObOggADkeACAAIKOgA==
Date: Fri, 11 Dec 2015 07:33:11 +0000
Message-ID: <02dd0f8d7f8e4cacb9e54a067fd483e4@HKXPR3004MB0088.064d.mgd.msft.net>
References: <1446167538-19409-1-git-send-email-kys@microsoft.com>
 <1446167566-19448-1-git-send-email-kys@microsoft.com>
 <1446167566-19448-2-git-send-email-kys@microsoft.com>
 <dfbacd7b8ec14d5b963408697fd33e73@HKXPR3004MB0088.064d.mgd.msft.net>
 <BY2PR0301MB16541AAA6481D02387FEF713A0E90@BY2PR0301MB1654.namprd03.prod.outlook.com>
In-Reply-To: <BY2PR0301MB16541AAA6481D02387FEF713A0E90@BY2PR0301MB1654.namprd03.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: multipart/mixed;
	boundary="_002_02dd0f8d7f8e4cacb9e54a067fd483e4HKXPR3004MB0088064dmgdm_"
MIME-Version: 1.0
SpamDiagnosticOutput: 1:23
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Dec 2015 07:33:19.2815
 (UTC)
X-MS-Exchange-CrossTenant-Id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=72f988bf-86f1-41af-91ab-2d7cd011db47;Ip=[23.103.249.84];Helo=[064-smtp-out.microsoft.com]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0301MB0731
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 9347
Lines: 193

--_002_02dd0f8d7f8e4cacb9e54a067fd483e4HKXPR3004MB0088064dmgdm_
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

> -----Original Message-----
> From: KY Srinivasan
> Sent: Friday, December 11, 2015 7:23
> > It looks the patch has not been Greg's tree yet.
> >
> > I have 2 questions about the patch:
> >
> > 1. hv_poll_channel() is invoked in fcopy_handle_handshake(), but not in
> > vss_handle_handshake() and kvp_handle_handshake().
> > Why -- I guess we missed the vss/kvp cases somehow?
> I will fix this.

Thanks, KY!
BTW, I fixed another small issue by https://lkml.org/lkml/2015/12/10/50
(The mail is attached for your convenience)

> > 2.  With the patch, hv_fcopy_onchannelcallback() can be invoked in the
> > tasklet (i.e., vmbus_on_event(). NB: local irq is enabled), and in the
> > hard irq handler(the IPI handler, e.g.,
> > fcopy_poll_wrapper() -> fcopy_poll_wrapper()).
> >
> > Can the former be interrupted by the latter?
> > e.g., when the callback is running in the tasklet on vCPU0,
> > fcopy_timeout_func() or fcopy_on_msg() could send the IPI to
> > vCPU0 from another vCPU.
>=20
> Keep in mind that when the poll function is run, the state will not be
> HVUTIL_READY. The state will be set to HVUTIL_READY in the IPI
> handler. So, it is ok if the tasklet is interrupted by the IPI handler.
>=20
> K. Y

Got it.

BTW, in fcopy_handle_handshake(), IMO the line
fcopy_transaction.state =3D HVUTIL_READY;
just before=20
hv_poll_channel(fcopy_transaction.recv_channel, fcopy_poll_wrapper);
should be removed? Because in fcopy_poll_wrapper() we always have
the same line.=20

Ditto for kvp/vss.

Thanks,
-- Dexuan

--_002_02dd0f8d7f8e4cacb9e54a067fd483e4HKXPR3004MB0088064dmgdm_
Content-Type: message/rfc822
Content-Disposition: attachment;
	creation-date="Fri, 11 Dec 2015 07:33:09 GMT";
	modification-date="Fri, 11 Dec 2015 07:33:09 GMT"

Received: from HKXPR3004MB0087.064d.mgd.msft.net (141.251.197.87) by
 HKXPR3004MB0088.064d.mgd.msft.net (141.251.197.88) with Microsoft SMTP Server
 (TLS) id 15.1.355.11 via Mailbox Transport; Thu, 10 Dec 2015 07:39:05 +0000
Received: from DB3PR30CA004.064d.mgd.msft.net (141.251.50.14) by
 HKXPR3004MB0087.064d.mgd.msft.net (141.251.197.87) with Microsoft SMTP Server
 (TLS) id 15.1.355.11; Thu, 10 Dec 2015 07:39:04 +0000
Received: from na01-bn1-obe.outbound.protection.outlook.com (207.46.163.182)
 by cloudmail.microsoft.com (141.251.50.14) with Microsoft SMTP Server (TLS)
 id 15.1.337.9 via Frontend Transport; Thu, 10 Dec 2015 07:39:03 +0000
Received: from BY2PR03CA011.namprd03.prod.outlook.com (10.255.93.28) by
 BY2PR0301MB1975.namprd03.prod.outlook.com (10.163.196.21) with Microsoft SMTP
 Server (TLS) id 15.1.337.19; Thu, 10 Dec 2015 07:39:01 +0000
Received: from BN1BFFO11FD047.protection.gbl (10.255.93.4) by
 BY2PR03CA011.outlook.office365.com (10.255.93.28) with Microsoft SMTP Server
 (TLS) id 15.1.355.16 via Frontend Transport; Thu, 10 Dec 2015 07:39:01 +0000
Received: from whitealder.osuosl.org (140.211.166.138) by
 BN1BFFO11FD047.mail.protection.outlook.com (10.58.145.2) with Microsoft SMTP
 Server id 15.1.337.8 via Frontend Transport; Thu, 10 Dec 2015 07:39:01 +0000
Received: from localhost (localhost [127.0.0.1])
	by whitealder.osuosl.org (Postfix) with ESMTP id 498609264D;
	Thu, 10 Dec 2015 07:39:00 +0000 (UTC)
Received: from whitealder.osuosl.org ([127.0.0.1])
	by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 2c+Yjqrln4vK; Thu, 10 Dec 2015 07:38:59 +0000 (UTC)
Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34])
	by whitealder.osuosl.org (Postfix) with ESMTP id 9C88792647;
	Thu, 10 Dec 2015 07:38:57 +0000 (UTC)
Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])
 by ash.osuosl.org (Postfix) with ESMTP id 9B8731C0FE5
 for <driverdev-devel@linuxdriverproject.org>;
 Thu, 10 Dec 2015 07:38:56 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1])
 by hemlock.osuosl.org (Postfix) with ESMTP id 9882F958D3
 for <driverdev-devel@linuxdriverproject.org>;
 Thu, 10 Dec 2015 07:38:56 +0000 (UTC)
Received: from hemlock.osuosl.org ([127.0.0.1])
 by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id NU4ZVczs+SGN
 for <driverdev-devel@linuxdriverproject.org>;
 Thu, 10 Dec 2015 07:38:54 +0000 (UTC)
Received: from p3plsmtps2ded03.prod.phx3.secureserver.net
 (p3plsmtps2ded03.prod.phx3.secureserver.net [208.109.80.60])
 by hemlock.osuosl.org (Postfix) with ESMTPS id D1D4A958BF
 for <driverdev-devel@linuxdriverproject.org>;
 Thu, 10 Dec 2015 07:38:54 +0000 (UTC)
Received: from linuxonhyperv.com ([72.167.245.219])
 by : HOSTING RELAY : with SMTP
 id 6vdZaNqG7sHQS6vdZaqHc6; Thu, 10 Dec 2015 00:27:38 -0700
Received: by linuxonhyperv.com (Postfix, from userid 518)
 id 830121904CF; Thu, 10 Dec 2015 01:00:57 -0800 (PST)
From: Dexuan Cui <decui@microsoft.com>
To: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"driverdev-devel@linuxdriverproject.org"
	<driverdev-devel@linuxdriverproject.org>, "olaf@aepfle.de" <olaf@aepfle.de>,
	"apw@canonical.com" <apw@canonical.com>, "jasowang@redhat.com"
	<jasowang@redhat.com>, KY Srinivasan <kys@microsoft.com>,
	"vkuznets@redhat.com" <vkuznets@redhat.com>
CC: Haiyang Zhang <haiyangz@microsoft.com>
Subject: [PATCH] tools: hv: vss: fix the write()'s argument: error -> vss_msg
Thread-Topic: [PATCH] tools: hv: vss: fix the write()'s argument: error ->
 vss_msg
Thread-Index: AQHRMx3Y8Kqb5/Wn20GjlJ0CCapg2g==
Sender: devel <driverdev-devel-bounces@linuxdriverproject.org>
Date: Thu, 10 Dec 2015 09:00:57 +0000
Message-ID: <1449738057-4596-1-git-send-email-decui@microsoft.com>
List-Help: <mailto:driverdev-devel-request@linuxdriverproject.org?subject=help>
List-Subscribe: <http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel>,
  <mailto:driverdev-devel-request@linuxdriverproject.org?subject=subscribe>
List-Unsubscribe: <https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fdriverdev.linuxdriverproject.org%2fmailman%2foptions%2fdriverdev-devel&data=01%7c01%7cdecui%40064d.mgd.microsoft.com%7c6038ce2d24784746fa0408d30134f8d9%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=uVe%2fFxSmkOo%2boUm%2fwp7WIfit9tFVSThNDargxFNxikQ%3d>,
  <mailto:driverdev-devel-request@linuxdriverproject.org?subject=unsubscribe>
Content-Language: en-US
X-MS-Exchange-Organization-AuthSource: BN1BFFO11FD047.protection.gbl
X-MS-Has-Attach: 
X-Auto-Response-Suppress: All
X-MS-Exchange-Organization-Network-Message-Id: bb0285ab-c675-4033-6e69-08d30134fa7d
X-Message-Flag: Follow up
X-MS-TNEF-Correlator: 
x-originating-ip: 72.167.245.219
received-spf: None (protection.outlook.com: linuxdriverproject.org does not
 designate permitted sender hosts)
x-organizationheaderspreserved: BY2PR0301MB1975.namprd03.prod.outlook.com
x-crosspremisesheaderspromoted: DB3PR30CA004.064d.mgd.msft.net
x-forefront-antispam-report: CIP:140.211.166.138;CTRY:US;IPV:NLI;EFV:NLI;SFV:SKS;SFS:;DIR:INB;SFP:;SCL:9;SRVR:BY2PR0301MB1975;H:whitealder.osuosl.org;FPR:;SPF:None;LANG:en;
x-originatororg: microsoft.onmicrosoft.com
x-crosspremisesheadersfiltered: DB3PR30CA004.064d.mgd.msft.net
authentication-results: spf=none (sender IP is 140.211.166.138)
 smtp.mailfrom=linuxdriverproject.org; microsoft.com; dkim=none (message not
 signed) header.d=none;microsoft.com; dmarc=fail action=none
 header.from=microsoft.com;
Content-Type: text/plain; charset="us-ascii"
Content-ID: <EF1592E16D41D045A18B9A38E46C13E4@064d.mgd.microsoft.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

I found this by chance. I don't have a specific bug caused by this.

Cc: Vitaly Kuznetsov <vkuznets@redhat.com>
Cc: "K. Y. Srinivasan" <kys@microsoft.com>
Signed-off-by: Dexuan Cui <decui@microsoft.com>
Cc: stable@vger.kernel.org
---
 tools/hv/hv_vss_daemon.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/hv/hv_vss_daemon.c b/tools/hv/hv_vss_daemon.c
index 96234b6..5d51d6f 100644
--- a/tools/hv/hv_vss_daemon.c
+++ b/tools/hv/hv_vss_daemon.c
@@ -254,7 +254,7 @@ int main(int argc, char *argv[])
                        syslog(LOG_ERR, "Illegal op:%d\n", op);
                }
                vss_msg->error =3D error;
-               len =3D write(vss_fd, &error, sizeof(struct hv_vss_msg));
+               len =3D write(vss_fd, vss_msg, sizeof(struct hv_vss_msg));
                if (len !=3D sizeof(struct hv_vss_msg)) {
                        syslog(LOG_ERR, "write failed; error: %d %s", errno=
,
                               strerror(errno));
--
1.9.1

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
https://na01.safelinks.protection.outlook.com/?url=3Dhttp%3a%2f%2fdriverdev=
.linuxdriverproject.org%2fmailman%2flistinfo%2fdriverdev-devel&data=3D01%7c=
01%7cdecui%40064d.mgd.microsoft.com%7c6038ce2d24784746fa0408d30134f8d9%7c72=
f988bf86f141af91ab2d7cd011db47%7c1&sdata=3D6Hs1UNlA11wBtnU5XvHhpCgkUlIhWVMK=
xPHVj9UAZq8%3d

--_002_02dd0f8d7f8e4cacb9e54a067fd483e4HKXPR3004MB0088064dmgdm_--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/