Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753920AbbLKH7q (ORCPT ); Fri, 11 Dec 2015 02:59:46 -0500 Received: from us01smtprelay-2.synopsys.com ([198.182.60.111]:49976 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753387AbbLKH7o convert rfc822-to-8bit (ORCPT ); Fri, 11 Dec 2015 02:59:44 -0500 From: Vineet Gupta To: Marc Zyngier , Noam Camus , "linux-snps-arc@lists.infradead.org" CC: "linux-kernel@vger.kernel.org" , "cmetcalf@ezchip.com" , Thomas Gleixner , Jason Cooper Subject: Re: [PATCH v3 04/18] irqchip: add nps Internal and external irqchips Thread-Topic: [PATCH v3 04/18] irqchip: add nps Internal and external irqchips Thread-Index: AQHRLDnBeZmNGeyOjEiAnkOPiDVOqA== Date: Fri, 11 Dec 2015 07:58:51 +0000 Message-ID: References: <1448974985-11487-1-git-send-email-noamc@ezchip.com> <1448974985-11487-5-git-send-email-noamc@ezchip.com> <565DA0B6.5080903@arm.com> Accept-Language: en-US, en-IN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.12.197.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1233 Lines: 36 On Tuesday 01 December 2015 06:59 PM, Marc Zyngier wrote: >> +static int nps400_irq_map(struct irq_domain *d, unsigned int irq, >> > + irq_hw_number_t hw) >> > +{ >> > + switch (irq) { >> > + case TIMER0_IRQ: >> > +#if defined(CONFIG_SMP) >> > + case IPI_IRQ: >> > +#endif >> > + irq_set_chip_and_handler(irq, &nps400_irq_chip_percpu, >> > + handle_percpu_irq); >> > + break; >> > + default: >> > + irq_set_chip_and_handler(irq, &nps400_irq_chip_fasteoi, >> > + handle_fasteoi_irq); >> > + break; >> > + } > No. This is just wrong. Either you get per interrupt information from > the device tree to configure the interrupt the right way, or you have > different interrupt controllers for each device. > > But using the Linux irq number is always wrong. You should only consider > the hwirq. The source is this incorrectness is ARC core intc code which also does the same thing and we get away with it because of the legacy domain usage. I'll fix that up. Thx, -Vineet -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/