Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754591AbbLKJep (ORCPT ); Fri, 11 Dec 2015 04:34:45 -0500 Received: from mail-io0-f171.google.com ([209.85.223.171]:33342 "EHLO mail-io0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753129AbbLKJem (ORCPT ); Fri, 11 Dec 2015 04:34:42 -0500 MIME-Version: 1.0 In-Reply-To: <566A5997.9020908@linaro.org> References: <566A5997.9020908@linaro.org> Date: Fri, 11 Dec 2015 17:34:41 +0800 Message-ID: Subject: Re: [RFC] kprobe'ing conditionally executed instructions From: Steve Capper To: David Long Cc: "Jon Medhurst (Tixy)" , Masami Hiramatsu , Ananth N Mavinakayanahalli , Anil S Keshavamurthy , David Miller , Will Deacon , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Sandeepa Prabhu , William Cohen , Pratyush Anand Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1361 Lines: 31 On 11 December 2015 at 13:05, David Long wrote: > There is a moderate amount of code already in kprobes on ARM and the current > ARMv8 patch to deal with conditional execution of instructions. One aspect > of how this is handled is that instructions that fail their predicate and > are not (technically) executed are also not treated as a hit kprobe. Steve > Capper has suggested that the probe handling should still take place because > we stepped through the instruction even if it was effectively a nop. This > would be a significant change in how it currently works on 32-bit ARM, and a > change in the patch for ARMv8 (although it's not likely to be much of a > change in the kernel code). > > I need input on this. Do people have opinions? Hi David, Thanks for posting this. Just to clarify the reasoning behind my suggestion for kprobes always being hit was to achieve parity with x86. I highlighted an example of discrepancy in behaviour between arm64 and x86 in the following email: http://lists.infradead.org/pipermail/linux-arm-kernel/2015-August/364201.html Cheers, -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/