Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754647AbbLKJfo (ORCPT ); Fri, 11 Dec 2015 04:35:44 -0500 Received: from mail-vk0-f47.google.com ([209.85.213.47]:34428 "EHLO mail-vk0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754330AbbLKJfm (ORCPT ); Fri, 11 Dec 2015 04:35:42 -0500 MIME-Version: 1.0 In-Reply-To: <20151211091632.GH28650@localhost> References: <1449780614-5933-1-git-send-email-geyslan@gmail.com> <20151211091632.GH28650@localhost> Date: Fri, 11 Dec 2015 06:35:41 -0300 Message-ID: Subject: Re: [PATCH 1/4] usb: serial: remove redundant conditions From: "Geyslan G. Bem" To: Johan Hovold Cc: Peter Senna Tschudin , Greg Kroah-Hartman , linux-usb@vger.kernel.org, LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1176 Lines: 41 2015-12-11 6:16 GMT-03:00 Johan Hovold : > On Thu, Dec 10, 2015 at 05:50:09PM -0300, Geyslan G. Bem wrote: >> This patch removes redundant conditions. >> >> (!A || (A && B)) is the same as (!A || B). >> (length && length > 5) can be reduced to a single evaluation. >> >> Tested by compilation only. >> Caught by cppcheck. >> >> Signed-off-by: Geyslan G. Bem >> --- >> drivers/usb/serial/io_edgeport.c | 35 ++++++++++++++--------------------- >> drivers/usb/serial/mos7840.c | 2 +- >> 2 files changed, 15 insertions(+), 22 deletions(-) > > Please split this up per driver as I (and Felipe) asked. Sorry. get_maintainer give same maintainers, but the question here is the different drivers. Ok, I'll send them splitted. > > You can send these two separate from the rest, and remember to CC > the USB list. Ok, tks. > > Thanks, > Johan -- Regards, Geyslan G. Bem hackingbits.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/