Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754789AbbLKKBd (ORCPT ); Fri, 11 Dec 2015 05:01:33 -0500 Received: from smtp105.iad3a.emailsrvr.com ([173.203.187.105]:47380 "EHLO smtp105.iad3a.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754638AbbLKKBa (ORCPT ); Fri, 11 Dec 2015 05:01:30 -0500 X-Auth-ID: abbotti@mev.co.uk X-Sender-Id: abbotti@mev.co.uk Subject: Re: [PATCH 0/2] staging: COMEDI: checkpatch.pl cleanups in comedi.h To: =?UTF-8?Q?Moritz_K=c3=b6nig?= , H Hartley Sweeten , Greg Kroah-Hartman , Colin Cronin , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org References: Cc: Fabian Lang , linux-kernel@i4.cs.fau.de From: Ian Abbott Message-ID: <566A9EF8.1050600@mev.co.uk> Date: Fri, 11 Dec 2015 10:01:28 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1684 Lines: 41 On 10/12/15 14:57, Moritz König wrote: > This patchset fixes all the warnings and legitimate checks of > checkpatch.pl in comedi.h. > > The following warnings were fixed: > * WARNING: Block comments use * on subsequent lines > * WARNING: Block comments use a trailing */ on a separate line > The following checks were fixed: > * CHECK: spaces preferred around that '<<' (ctx:VxV) > * CHECK: spaces preferred around that '>>' (ctx:VxV) > * CHECK: spaces preferred around that '|' (ctx:VxV) > > The following checks are not legitimate here and were not fixed: > * CHECK: spaces preferred around that '&' (ctx:VxV) > This '&' is not a binary operator, but a referencing. > * CHECK: Prefer using the BIT macro > The author defined a BIT macro here. > * CHECK: Avoid CamelCase: > This refers to the unit 'milli ampere'. > > Moritz König (2): > staging: COMEDI: Fixed the format of comments > staging: COMEDI: Added missing spaces at binary operators > > drivers/staging/comedi/comedi.h | 232 +++++++++++++++++++++++----------------- > 1 file changed, 131 insertions(+), 101 deletions(-) > Thanks. There's an outstanding patch by Daniel H. Hemmingsen that also fixes these issues: http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2015-November/081778.html -- -=( Ian Abbott @ MEV Ltd. E-mail: )=- -=( Web: http://www.mev.co.uk/ )=- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/