Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752923AbbLKLOm (ORCPT ); Fri, 11 Dec 2015 06:14:42 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:40688 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751531AbbLKLOl (ORCPT ); Fri, 11 Dec 2015 06:14:41 -0500 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: brcmfmac: only lock and unlock fws if fws is not null From: Kalle Valo In-Reply-To: <1449056710-9776-1-git-send-email-colin.king@canonical.com> To: Colin Ian King Cc: kernel-tram@lists.ubuntu.com, Brett Rudley , Arend van Spriel , Franky Lin , Hante Meuleman , Pieter-Paul Giesberts , Arnd Bergmann , linux-wireless@vger.kernel.org, brcm80211-dev-list@broadcom.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Message-Id: <20151211111440.67B29141A65@smtp.codeaurora.org> Date: Fri, 11 Dec 2015 11:14:40 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 673 Lines: 18 > From: Colin Ian King > > There is a null ptr check for fws to set bcmc_credit_check, however, > there a lock and unlock on fws should only performed if fwts is > also not null to also avoid a potential null pointer deference. > > Signed-off-by: Colin Ian King > Acked-by: Arend van Spriel Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/