Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755130AbbLKMPA (ORCPT ); Fri, 11 Dec 2015 07:15:00 -0500 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:7408 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754770AbbLKMO6 (ORCPT ); Fri, 11 Dec 2015 07:14:58 -0500 X-IronPort-AV: E=Sophos;i="5.20,413,1444687200"; d="scan'208";a="191551905" Date: Fri, 11 Dec 2015 13:14:51 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: SF Markus Elfring cc: LKML , kernel-janitors@vger.kernel.org, "Derek M. Jones" Subject: Re: Source code review around jump label usage In-Reply-To: <566ABCD9.1060404@users.sourceforge.net> Message-ID: References: <566ABCD9.1060404@users.sourceforge.net> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 864 Lines: 18 > Do any of these numbers indicate update candidates which correspond to the > "one error jump label bug" symptom that is mentioned in the Linux coding > style documentation? I don't think that numbers could indicate that. The point of that is a single label followed by a bunch of ifs, or by calls to functions that perform tests on input validity. That is, it is the content of the code that causes the problem, not its size. Dan also discourages the use of labels like out, that don't indicate anything about anything, or kmalloc_err, which don't indicate anything about what happens at the label target. julia -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/