Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753412AbbLKMax (ORCPT ); Fri, 11 Dec 2015 07:30:53 -0500 Received: from mail-lb0-f169.google.com ([209.85.217.169]:34044 "EHLO mail-lb0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751818AbbLKMaw (ORCPT ); Fri, 11 Dec 2015 07:30:52 -0500 Subject: Re: [PATCH 2/2] usb: serial: remove redundant condition To: "Geyslan G. Bem" , peter.senna@gmail.com References: <1449827205-3967-1-git-send-email-geyslan@gmail.com> <1449827205-3967-2-git-send-email-geyslan@gmail.com> Cc: Johan Hovold , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org From: Sergei Shtylyov Message-ID: <566AC1F8.6010802@cogentembedded.com> Date: Fri, 11 Dec 2015 15:30:48 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <1449827205-3967-2-git-send-email-geyslan@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 657 Lines: 24 Hello. On 12/11/2015 12:46 PM, Geyslan G. Bem wrote: It's a bad idea to send 2 different patches with the same subject. I'd use "mos7840: " as a prefix in this case. > This patch removes redundant condition. > > (length && length > 5) can be reduced to a single evaluation. > > Tested by compilation only. > Caught by cppcheck. > > Signed-off-by: Geyslan G. Bem [...] MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/