Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755193AbbLKMuT (ORCPT ); Fri, 11 Dec 2015 07:50:19 -0500 Received: from mail-ob0-f171.google.com ([209.85.214.171]:36428 "EHLO mail-ob0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751187AbbLKMuR convert rfc822-to-8bit (ORCPT ); Fri, 11 Dec 2015 07:50:17 -0500 MIME-Version: 1.0 In-Reply-To: <20151211124159.GB3729@pathway.suse.cz> References: <1449667265-17525-1-git-send-email-pmladek@suse.com> <1449667265-17525-5-git-send-email-pmladek@suse.com> <20151211124159.GB3729@pathway.suse.cz> Date: Fri, 11 Dec 2015 13:50:16 +0100 X-Google-Sender-Auth: -DK7eicFw73OJxLZM7NLOUVCdnQ Message-ID: Subject: Re: [PATCH v3 4/4] printk/nmi: Increase the size of NMI buffer and make it configurable From: Geert Uytterhoeven To: Petr Mladek Cc: Andrew Morton , Peter Zijlstra , Steven Rostedt , Russell King , Daniel Thompson , Jiri Kosina , Ingo Molnar , Thomas Gleixner , "linux-kernel@vger.kernel.org" , "the arch/x86 maintainers" , "linux-arm-kernel@lists.infradead.org" , "adi-buildroot-devel@lists.sourceforge.net" , Cris , Linux MIPS Mailing List , "linuxppc-dev@lists.ozlabs.org" , linux-s390 , Linux-sh list , sparclinux Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2119 Lines: 56 On Fri, Dec 11, 2015 at 1:41 PM, Petr Mladek wrote: > On Fri 2015-12-11 12:10:02, Geert Uytterhoeven wrote: >> On Wed, Dec 9, 2015 at 2:21 PM, Petr Mladek wrote: >> > --- a/init/Kconfig >> > +++ b/init/Kconfig >> > @@ -866,6 +866,28 @@ config LOG_CPU_MAX_BUF_SHIFT >> > 13 => 8 KB for each CPU >> > 12 => 4 KB for each CPU >> > >> > +config NMI_LOG_BUF_SHIFT >> > + int "Temporary per-CPU NMI log buffer size (12 => 4KB, 13 => 8KB)" >> > + range 10 21 >> > + default 13 >> > + depends on PRINTK && HAVE_NMI >> >> Symbol NMI_LOG_BUF_SHIFT does not exist if its dependencies are not met. > > Åh, the NMI buffer is enabled on arm via NEED_PRINTK_NMI. > > The buffer is compiled when CONFIG_PRINTK_NMI is defined. I am going > to fix it the following way: > > > diff --git a/init/Kconfig b/init/Kconfig > index efcff25a112d..61cfd96a3c96 100644 > --- a/init/Kconfig > +++ b/init/Kconfig > @@ -870,7 +870,7 @@ config NMI_LOG_BUF_SHIFT > int "Temporary per-CPU NMI log buffer size (12 => 4KB, 13 => 8KB)" > range 10 21 > default 13 > - depends on PRINTK && HAVE_NMI > + depends on PRINTK_NMI > help > Select the size of a per-CPU buffer where NMI messages are temporary > stored. They are copied to the main log buffer in a safe context Makes sense, as kernel/printk/nmi.c is compiled if PRINTK_NMI is set. Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/