Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755140AbbLKNDm (ORCPT ); Fri, 11 Dec 2015 08:03:42 -0500 Received: from sauhun.de ([89.238.76.85]:43635 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754058AbbLKNDl (ORCPT ); Fri, 11 Dec 2015 08:03:41 -0500 Date: Fri, 11 Dec 2015 14:03:25 +0100 From: Wolfram Sang To: Andrew Lunn Cc: GregKH , srinivas.kandagatla@linaro.org, maxime.ripard@free-electrons.com, broonie@kernel.org, vz@mleia.com, afd@ti.com, linux-kernel@vger.kernel.org, Pantelis Antoniou Subject: Re: [PATCH 2/6] nvmem: Add backwards compatibility support for older EEPROM drivers. Message-ID: <20151211130325.GB2742@katana> References: <1449583511-22521-1-git-send-email-andrew@lunn.ch> <1449583511-22521-3-git-send-email-andrew@lunn.ch> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="eJnRUKwClWJh1Khz" Content-Disposition: inline In-Reply-To: <1449583511-22521-3-git-send-email-andrew@lunn.ch> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3229 Lines: 81 --eJnRUKwClWJh1Khz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Dec 08, 2015 at 03:05:07PM +0100, Andrew Lunn wrote: > Older drivers made an 'eeprom' file available in the /sys device > directory. Have the NVMEM core provide this to retain backwards > compatibility. >=20 > Signed-off-by: Andrew Lunn > --- > drivers/nvmem/Kconfig | 7 ++++ > drivers/nvmem/core.c | 75 ++++++++++++++++++++++++++++++++++++= +++--- > include/linux/nvmem-provider.h | 10 ++++++ > 3 files changed, 88 insertions(+), 4 deletions(-) >=20 > diff --git a/drivers/nvmem/Kconfig b/drivers/nvmem/Kconfig > index bc4ea585b42e..b4e79ba7d502 100644 > --- a/drivers/nvmem/Kconfig > +++ b/drivers/nvmem/Kconfig > @@ -13,6 +13,13 @@ menuconfig NVMEM > If unsure, say no. > =20 > if NVMEM > +config NVMEM_COMPAT > + bool "Enable /sys compatibility with old eeprom drivers" > + help > + Older EEPROM drivers, such as AT24, AT25, provide access to > + the eeprom via a file called "eeprom" in /sys under the > + device node. Enabling this option makes the NVMEM core > + provide this file to retain backwards compatibility I don't like this being a Kconfig option TBH. In most cases, when I read "retain backwards compatibility" in Kconfig help texts, I keep the option activated because I don't know the details when exactly it is safe to disable it. Plus, we have too many Kconfig symbols already. I suggest to add this flag to nvmem_config and let the old eeprom drivers always set this flag because they need to provide this file for some more time, if not forever. New drivers using the nvmem_layer will probably not want to set this. BTW how does this NVMEM framework relate to the memory_accessor framework. Can it be used to replace it? I think we should keep the number of eeprom interfaces at a sane level, preferably 1 ;) Also adding Pantelis to CC who also submitted at24 NVMEM support a while ago. --eJnRUKwClWJh1Khz Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWasmdAAoJEBQN5MwUoCm24UcP/jCBcanDQmTjxzgOpQp/mtOs f5IOQnt492I1mgIweXK+xgpzxzTWsFQE3FdWxcUbEDtwsJDhlaCW05ibtG3MOU4o JmZIIfKEKYBiSPjqmhrqOixmskW6XRHiPUp53YTKUeLCsrCotWo+vhHwTGDRIxLf /a1seOBVKaadzk4qvnzhLY3+d74D2KdQLS8tHiAK0GyX4TLA2pLaheozvnImjl3D cpyc0uc+NngZQO7+Fg5kU41JYP06tZVNMxCXkY7R/Ged2i/lwauaNWFC84VGsXcP 5b9PG+QCARyXM+/YtGZLLLG3NXhTjNA1IEVrzTIn1I9mr4nLh6YKL2FOSoamM9bo Olv9ipU1qOo8eA5FBMIaqSsqKyZdxSxj4r5USwASwNxpmJtjzKnk9tAxO76fUDG9 VxSWLBiuexPEJvAsdLubSCtmV0gt2wZ9RV8CP9n/Ee8LRf7S/fAEDekA2EOjwb/h 8J5BYdkSYIRzT6EcAMx+auEsdPQiydFBJoVLik6nAVxY34nLE3HKhfRJcW7MWJeC e9dDw31llLBefGguIZ9bKxSrHkl5uxYKzmb345HYpX7i/TwoizcPxQBKLVKhq1eD Z/AtTsTasn3N6ZiBzYQzIQ3iIlgwlO+7i61JFoVcvgMrk0IMFef8ckdjsKG+GFgh doaN2iNMmQKrHzuleRWo =mkq+ -----END PGP SIGNATURE----- --eJnRUKwClWJh1Khz-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/