Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755351AbbLKPKQ (ORCPT ); Fri, 11 Dec 2015 10:10:16 -0500 Received: from down.free-electrons.com ([37.187.137.238]:34411 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753951AbbLKPKL (ORCPT ); Fri, 11 Dec 2015 10:10:11 -0500 Date: Fri, 11 Dec 2015 16:10:08 +0100 From: Boris Brezillon To: David Woodhouse , Brian Norris , linux-mtd@lists.infradead.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Jonathan Corbet , linux-doc@vger.kernel.org, Hartley Sweeten , Ryan Mallon , Shawn Guo , Sascha Hauer , Imre Kaloz , Krzysztof Halasa , Tony Lindgren , linux-omap@vger.kernel.org, Alexander Clouter , Thomas Petazzoni , Gregory CLEMENT , Jason Cooper , Sebastian Hesselbarth , Andrew Lunn , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Marek Vasut , Steven Miao , Mikael Starvik , Jesper Nilsson , linux-cris-kernel@axis.com, Nicolas Ferre , Jean-Christophe Plagniol-Villard , Alexandre Belloni , Wan ZongShun , Ezequiel Garcia , Maxim Levitsky , Kukjin Kim , Krzysztof Kozlowski , linux-samsung-soc@vger.kernel.org, Maxime Ripard , Chen-Yu Tsai , linux-sunxi@googlegroups.com, Stefan Agner , Greg Kroah-Hartman , devel@driverdev.osuosl.org, Dinh Nguyen , Dan Carpenter Subject: Re: [PATCH v5 01/58] mtd: nand: denali: add missing nand_release() call in denali_remove() Message-ID: <20151211161008.056a0f47@bbrezillon> In-Reply-To: <1449842554-29898-1-git-send-email-boris.brezillon@free-electrons.com> References: <1449734442-18672-2-git-send-email-boris.brezillon@free-electrons.com> <1449842554-29898-1-git-send-email-boris.brezillon@free-electrons.com> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.27; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1816 Lines: 54 + Dinh (who made commit 2a0a288ec258) Also added back the Fixes tag. On Fri, 11 Dec 2015 15:02:34 +0100 Boris Brezillon wrote: > Unregister the NAND device from the NAND subsystem when removing a denali > NAND controller, otherwise the MTD attached to the NAND device is still > exposed by the MTD layer, and accesses to this device will likely crash > the system. > > Signed-off-by: Boris Brezillon Fixes: 2a0a288ec258 ("mtd: denali: split the generic driver and PCI layer") > --- > Changes since v4: > - remove Cc stable and fixes tags > - calculate the dma buffer size before calling nand_release() > > drivers/mtd/nand/denali.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/mtd/nand/denali.c b/drivers/mtd/nand/denali.c > index 67eb2be..fdfea05 100644 > --- a/drivers/mtd/nand/denali.c > +++ b/drivers/mtd/nand/denali.c > @@ -1622,9 +1622,11 @@ EXPORT_SYMBOL(denali_init); > /* driver exit point */ > void denali_remove(struct denali_nand_info *denali) > { > + int bufsize = denali->mtd.writesize + denali->mtd.oobsize; > + > + nand_release(&denali->mtd); > denali_irq_cleanup(denali->irq, denali); > - dma_unmap_single(denali->dev, denali->buf.dma_buf, > - denali->mtd.writesize + denali->mtd.oobsize, > + dma_unmap_single(denali->dev, denali->buf.dma_buf, bufsize, > DMA_BIDIRECTIONAL); > } > EXPORT_SYMBOL(denali_remove); -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/