Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754239AbbLKPRW (ORCPT ); Fri, 11 Dec 2015 10:17:22 -0500 Received: from dehamd003.servertools24.de ([31.47.254.18]:53963 "EHLO dehamd003.servertools24.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751043AbbLKPRV (ORCPT ); Fri, 11 Dec 2015 10:17:21 -0500 Subject: Re: [PATCH] ALSA: usb-audio: constify usb_protocol_ops structures To: Takashi Iwai References: <1449845557-22444-1-git-send-email-Julia.Lawall@lip6.fr> Cc: Julia Lawall , kernel-janitors@vger.kernel.org, Jaroslav Kysela , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org From: Clemens Ladisch Message-ID: <566AE8FB.4000502@ladisch.de> Date: Fri, 11 Dec 2015 16:17:15 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <1449845557-22444-1-git-send-email-Julia.Lawall@lip6.fr> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-PPP-Message-ID: <20151211151716.697085.79729@dehamd003.servertools24.de> X-PPP-Vhost: ladisch.de Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4857 Lines: 124 Julia Lawall wrote: > The usb_protocol_ops structures are never modified, so declare them as > const. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall Acked-by: Clemens Ladisch > --- > sound/usb/midi.c | 25 +++++++++++++------------ > 1 file changed, 13 insertions(+), 12 deletions(-) > > diff --git a/sound/usb/midi.c b/sound/usb/midi.c > index ee212e7..cc39f63 100644 > --- a/sound/usb/midi.c > +++ b/sound/usb/midi.c > @@ -112,7 +112,7 @@ struct snd_usb_midi { > struct usb_interface *iface; > const struct snd_usb_audio_quirk *quirk; > struct snd_rawmidi *rmidi; > - struct usb_protocol_ops *usb_protocol_ops; > + const struct usb_protocol_ops *usb_protocol_ops; > struct list_head list; > struct timer_list error_timer; > spinlock_t disc_lock; > @@ -671,31 +671,32 @@ static void snd_usbmidi_standard_output(struct snd_usb_midi_out_endpoint *ep, > } > } > > -static struct usb_protocol_ops snd_usbmidi_standard_ops = { > +static const struct usb_protocol_ops snd_usbmidi_standard_ops = { > .input = snd_usbmidi_standard_input, > .output = snd_usbmidi_standard_output, > .output_packet = snd_usbmidi_output_standard_packet, > }; > > -static struct usb_protocol_ops snd_usbmidi_midiman_ops = { > +static const struct usb_protocol_ops snd_usbmidi_midiman_ops = { > .input = snd_usbmidi_midiman_input, > .output = snd_usbmidi_standard_output, > .output_packet = snd_usbmidi_output_midiman_packet, > }; > > -static struct usb_protocol_ops snd_usbmidi_maudio_broken_running_status_ops = { > +static const > +struct usb_protocol_ops snd_usbmidi_maudio_broken_running_status_ops = { > .input = snd_usbmidi_maudio_broken_running_status_input, > .output = snd_usbmidi_standard_output, > .output_packet = snd_usbmidi_output_standard_packet, > }; > > -static struct usb_protocol_ops snd_usbmidi_cme_ops = { > +static const struct usb_protocol_ops snd_usbmidi_cme_ops = { > .input = snd_usbmidi_cme_input, > .output = snd_usbmidi_standard_output, > .output_packet = snd_usbmidi_output_standard_packet, > }; > > -static struct usb_protocol_ops snd_usbmidi_ch345_broken_sysex_ops = { > +static const struct usb_protocol_ops snd_usbmidi_ch345_broken_sysex_ops = { > .input = ch345_broken_sysex_input, > .output = snd_usbmidi_standard_output, > .output_packet = snd_usbmidi_output_standard_packet, > @@ -795,7 +796,7 @@ static void snd_usbmidi_akai_output(struct snd_usb_midi_out_endpoint *ep, > } > } > > -static struct usb_protocol_ops snd_usbmidi_akai_ops = { > +static const struct usb_protocol_ops snd_usbmidi_akai_ops = { > .input = snd_usbmidi_akai_input, > .output = snd_usbmidi_akai_output, > }; > @@ -835,7 +836,7 @@ static void snd_usbmidi_novation_output(struct snd_usb_midi_out_endpoint *ep, > urb->transfer_buffer_length = 2 + count; > } > > -static struct usb_protocol_ops snd_usbmidi_novation_ops = { > +static const struct usb_protocol_ops snd_usbmidi_novation_ops = { > .input = snd_usbmidi_novation_input, > .output = snd_usbmidi_novation_output, > }; > @@ -867,7 +868,7 @@ static void snd_usbmidi_raw_output(struct snd_usb_midi_out_endpoint *ep, > urb->transfer_buffer_length = count; > } > > -static struct usb_protocol_ops snd_usbmidi_raw_ops = { > +static const struct usb_protocol_ops snd_usbmidi_raw_ops = { > .input = snd_usbmidi_raw_input, > .output = snd_usbmidi_raw_output, > }; > @@ -883,7 +884,7 @@ static void snd_usbmidi_ftdi_input(struct snd_usb_midi_in_endpoint *ep, > snd_usbmidi_input_data(ep, 0, buffer + 2, buffer_length - 2); > } > > -static struct usb_protocol_ops snd_usbmidi_ftdi_ops = { > +static const struct usb_protocol_ops snd_usbmidi_ftdi_ops = { > .input = snd_usbmidi_ftdi_input, > .output = snd_usbmidi_raw_output, > }; > @@ -927,7 +928,7 @@ static void snd_usbmidi_us122l_output(struct snd_usb_midi_out_endpoint *ep, > urb->transfer_buffer_length = ep->max_transfer; > } > > -static struct usb_protocol_ops snd_usbmidi_122l_ops = { > +static const struct usb_protocol_ops snd_usbmidi_122l_ops = { > .input = snd_usbmidi_us122l_input, > .output = snd_usbmidi_us122l_output, > }; > @@ -1060,7 +1061,7 @@ static void snd_usbmidi_emagic_output(struct snd_usb_midi_out_endpoint *ep, > urb->transfer_buffer_length = ep->max_transfer - buf_free; > } > > -static struct usb_protocol_ops snd_usbmidi_emagic_ops = { > +static const struct usb_protocol_ops snd_usbmidi_emagic_ops = { > .input = snd_usbmidi_emagic_input, > .output = snd_usbmidi_emagic_output, > .init_out_endpoint = snd_usbmidi_emagic_init_out, -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/