Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754273AbbLKPbz (ORCPT ); Fri, 11 Dec 2015 10:31:55 -0500 Received: from mx1.redhat.com ([209.132.183.28]:54264 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751862AbbLKPbx (ORCPT ); Fri, 11 Dec 2015 10:31:53 -0500 Subject: Re: [PATCHv4 1/1] SCSI: hosts: update to use ida_simple for host_no management From: Ewan Milne Reply-To: emilne@redhat.com To: Lee Duncan Cc: "Martin K. Petersen" , Hannes Reinecke , James Bottomley , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Tejun Heo , Hannes Reinecke , Johannes Thumshirn , Christoph Hellwig In-Reply-To: <5669F31C.2010409@suse.com> References: <1444830904.2220.28.camel@HansenPartnership.com> <561EA018.7020700@suse.com> <1444848835.2220.50.camel@HansenPartnership.com> <5644BEE1.3010208@suse.com> <5649C79E.9070603@suse.de> <564A4EDC.8060805@suse.com> <5669F31C.2010409@suse.com> Content-Type: text/plain; charset="UTF-8" Organization: Red Hat Date: Fri, 11 Dec 2015 10:31:51 -0500 Message-ID: <1449847911.4067.200.camel@localhost.localdomain> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1368 Lines: 37 On Thu, 2015-12-10 at 13:48 -0800, Lee Duncan wrote: > On 11/17/2015 03:20 PM, Martin K. Petersen wrote: > >>>>>> "Lee" == Lee Duncan writes: > > > > Lee> Martin: I will be glad to update the patch, creating a modprobe > > Lee> parameter as suggested, if you find this acceptable. > > > > For development use a module parameter would be fine. But I am concerned > > about our support folks that rely on the incrementing host number when > > analyzing customer log files. > > > > Ewan: How do you folks feel about this change? > > > > Ewan? Personally, I think having host numbers that increase essentially without limit (I think I've seen this with iSCSI sessions) are a problem, the numbers start to lose meaning for people when they are not easily recognizable. Yes, it can help when you're analyzing a log file, but it seems to me that you would want to track the host state throughout anyway, so you could just follow the number as it changes. If we change the behavior, we have to change documentation, and our support people will get calls. But that's not a reason not to do it. -Ewan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/