Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755399AbbLKQJg (ORCPT ); Fri, 11 Dec 2015 11:09:36 -0500 Received: from exsmtp01.microchip.com ([198.175.253.37]:46921 "EHLO email.microchip.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755319AbbLKQJd (ORCPT ); Fri, 11 Dec 2015 11:09:33 -0500 Subject: Re: [PATCH 09/14] DEVICETREE: Add bindings for PIC32 usart driver To: Rob Herring References: <1448065205-15762-1-git-send-email-joshua.henderson@microchip.com> <1448065205-15762-10-git-send-email-joshua.henderson@microchip.com> <20151122215622.GA32221@rob-hp-laptop> CC: , , Andrei Pistirica , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , From: Joshua Henderson Message-ID: <566AF6DE.9030803@microchip.com> Date: Fri, 11 Dec 2015 09:16:30 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <20151122215622.GA32221@rob-hp-laptop> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2739 Lines: 79 Rob, On 11/22/2015 02:56 PM, Rob Herring wrote: > On Fri, Nov 20, 2015 at 05:17:21PM -0700, Joshua Henderson wrote: >> From: Andrei Pistirica >> >> Document the devicetree bindings for the USART peripheral found on >> Microchip PIC32 class devices. >> >> Signed-off-by: Andrei Pistirica >> Signed-off-by: Joshua Henderson >> --- >> .../bindings/serial/microchip,pic32-usart.txt | 29 ++++++++++++++++++++ >> 1 file changed, 29 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/serial/microchip,pic32-usart.txt >> >> diff --git a/Documentation/devicetree/bindings/serial/microchip,pic32-usart.txt b/Documentation/devicetree/bindings/serial/microchip,pic32-usart.txt >> new file mode 100644 >> index 0000000..c87321c >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/serial/microchip,pic32-usart.txt >> @@ -0,0 +1,29 @@ >> +* Microchip Universal Synchronous Asynchronous Receiver/Transmitter (USART) >> + >> +Required properties: >> +- compatible: Should be "microchip,pic32-usart" > > Again, should be more specific. > Ack. In addition, will replace all instances of USART with UART. >> +- reg: Should contain registers location and length >> +- interrupts: Should contain interrupt >> +- pinctrl: Should contain pinctrl for TX/RX/RTS/CTS >> + >> +Optional properties: >> +- microchip,uart-has-rtscts : Indicate the uart has hardware flow control >> +- rts-gpios: RTS pin for USP-based UART if microchip,uart-has-rtscts >> +- cts-gpios: CTS pin for USP-based UART if microchip,uart-has-rtscts > > This appears to just be copied for Sirf UART. > > Doesn't *-gpios being present imply having h/w > flow-control (i.e. microchip,uart-has-rtscts)? > > Rob Agreed. microchip,uart-has-rtscts will be dropped and it turns out we don't really need the rtc-gpios property. Josh > >> + >> +Example: >> + usart0: serial@1f822000 { >> + compatible = "microchip,pic32-usart"; >> + reg = <0x1f822000 0x50>; >> + interrupts = , >> + , >> + ; >> + pinctrl-names = "default"; >> + pinctrl-0 = < >> + &pinctrl_uart1 >> + &pinctrl_uart1_cts >> + &pinctrl_uart1_rts>; >> + microchip,uart-has-rtscts; >> + cts-gpios = <&pioB 15 0>; >> + rts-gpios = <&pioD 1 0>; >> + }; >> -- >> 1.7.9.5 >> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/