Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755630AbbLKUZS (ORCPT ); Fri, 11 Dec 2015 15:25:18 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:35852 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755607AbbLKUZP (ORCPT ); Fri, 11 Dec 2015 15:25:15 -0500 Date: Fri, 11 Dec 2015 11:30:19 -0500 From: Greg Kroah-Hartman To: "Geyslan G. Bem" Cc: peter.senna@gmail.com, Alan Stern , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 4/9] usb: host: ehci.h: fix single statement macros Message-ID: <20151211163019.GB9306@kroah.com> References: <1449771501-24976-1-git-send-email-geyslan@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1449771501-24976-1-git-send-email-geyslan@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 824 Lines: 24 On Thu, Dec 10, 2015 at 03:18:19PM -0300, Geyslan G. Bem wrote: > Don't use the 'do {} while (0)' wrapper in a single statement macro. > > Caught by checkpatch: "WARNING: Single statement macros should not > use a do {} while (0) loop" > > Signed-off-by: Geyslan G. Bem > --- > Change in v3: > - There's no need to evaluate COUNT(x) in #ifdef EHCI_STATS > false branch. Thus an empty #define is the choice. Odd numbering scheme of patches, I can't figure this out... Can you resend this whole series so I know I got it all correct? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/