Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755505AbbLKRd7 (ORCPT ); Fri, 11 Dec 2015 12:33:59 -0500 Received: from mail.kernel.org ([198.145.29.136]:40887 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753314AbbLKRd5 (ORCPT ); Fri, 11 Dec 2015 12:33:57 -0500 Date: Fri, 11 Dec 2015 11:33:53 -0600 From: Rob Herring To: Charles Keepax Cc: lee.jones@linaro.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.wolfsonmicro.com Subject: Re: [PATCH 2/2] mfd: arizona: Update binding docs for selecting mono/stereo outputs Message-ID: <20151211173353.GA7664@rob-hp-laptop> References: <1449829703-600-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> <1449829703-600-2-git-send-email-ckeepax@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1449829703-600-2-git-send-email-ckeepax@opensource.wolfsonmicro.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1679 Lines: 35 On Fri, Dec 11, 2015 at 10:28:23AM +0000, Charles Keepax wrote: > Update the device tree binding documentation to include the wlf,out-mono > property that is used to specify whether each output is a mono or stereo > output. You just added this binding and updating it already? While we may like kernel changes incremental, we don't like bindings evolving any more than necessary. > Signed-off-by: Charles Keepax > --- > Documentation/devicetree/bindings/mfd/arizona.txt | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mfd/arizona.txt b/Documentation/devicetree/bindings/mfd/arizona.txt > index 2b6ccdb..489dd07 100644 > --- a/Documentation/devicetree/bindings/mfd/arizona.txt > +++ b/Documentation/devicetree/bindings/mfd/arizona.txt > @@ -65,6 +65,10 @@ Optional properties: > that have not been specified are set to 0 by default. Entries are: > (wm5102, wm5110, wm8280, wm8997) > (wm8998, wm1814) > + - wlf,out-mono : A boolean indicating whether each output is mono or stereo. > + A non-zero value indicates a mono output. If present, the number of values > + should be less than or equal to the number of outputs, if less values are > + supplied the additional outputs will be treated as stereo. How do you know which outputs are which with a variable number? Rob -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/