Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752000AbbLKRyx (ORCPT ); Fri, 11 Dec 2015 12:54:53 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:43076 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751134AbbLKRyu (ORCPT ); Fri, 11 Dec 2015 12:54:50 -0500 Date: Fri, 11 Dec 2015 17:54:45 +0000 From: Mark Brown To: Juri Lelli Cc: Dietmar Eggemann , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, peterz@infradead.org, vincent.guittot@linaro.org, robh+dt@kernel.org, mark.rutland@arm.com, linux@arm.linux.org.uk, sudeep.holla@arm.com, lorenzo.pieralisi@arm.com, catalin.marinas@arm.com, will.deacon@arm.com, morten.rasmussen@arm.com Message-ID: <20151211175445.GR5727@sirena.org.uk> References: <1448288921-30307-1-git-send-email-juri.lelli@arm.com> <1448288921-30307-9-git-send-email-juri.lelli@arm.com> <566988E8.3010308@arm.com> <20151210155940.GN5727@sirena.org.uk> <20151210180159.GF14571@e106622-lin> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="xHTUIiWqaPwZ9IpM" Content-Disposition: inline In-Reply-To: <20151210180159.GF14571@e106622-lin> X-Cookie: revolutionary, adj.: User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [RFC PATCH 8/8] arm64: add sysfs cpu_capacity attribute X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2339 Lines: 56 --xHTUIiWqaPwZ9IpM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Dec 10, 2015 at 06:01:59PM +0000, Juri Lelli wrote: > On 10/12/15 15:59, Mark Brown wrote: > > On Thu, Dec 10, 2015 at 02:15:04PM +0000, Dietmar Eggemann wrote: > > > On 23/11/15 14:28, Juri Lelli wrote: > > > > The new attribute shows up as: > > > > /sys/devices/system/cpu/cpu*/cpu_capacity > > > This sysfs interface is not really needed for arm or arm64. People can > > > build the dt blob if they want to change the values. Less code to carry > > > ... Let's focus on the core functionality, which is parsing cpu capacity > > > from dt file to task scheduler for heterogeneous systems. > > That does make the tuning process much more cumbersome - users have to > > rebuild and reboot to tweak the numbers rather than just tweaking the > > numbers and rerunning the benchmark (which seems like something people > > would want to automate). > IMHO, this is not a tuning interface. It is an alternative interface, > w.r.t. DTs, that we could use to provide default capacity values to the > kernel. I'm proposing both here as they make both sense to me. Then we > might dedice for which one to go (or if we need some other way) or to > keep both for flexibility. Kind of repeating what I said in the other mail but I'd say that any interface which provides a mechanism for setting a magic number that influences system performance is providing tuning. It's hard to see how else to describe it to be honest. --xHTUIiWqaPwZ9IpM Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWaw3lAAoJECTWi3JdVIfQ3C8H/RzxQ/C/u1Vcmbwg6IvS0Emp g7UNshd1XpZI4sQW3ke9SD7k6f+IFiHuOyjuxjnat7Mgo1Vr/OVNEKVSt1cQvZPy O5OmeIKF2NsMAhDmETeUwqAH9AuVMXYn3soMNJSdaaFrrMR0Gw/y5J3iXnbHJFmZ ghWevuswglatAySYBtox+C8ClLStpYK7y+BYceENdOWo4z6kPG8hXGM70tGaLV7p f6CcGeXP0DwqOLQfhEb/HQHkeIouSSKwBi+dvsfL9xiqhr+UFBDeyagsJOs0Bo7b Oeqsj2djVcRyyH0GnGFndXOXLCRFtdDrMsRUmQKTWe0R4rFS1uwKxidT4iPmP9k= =BYmU -----END PGP SIGNATURE----- --xHTUIiWqaPwZ9IpM-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/