Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752196AbbLKSDq (ORCPT ); Fri, 11 Dec 2015 13:03:46 -0500 Received: from mail-ob0-f171.google.com ([209.85.214.171]:33789 "EHLO mail-ob0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751940AbbLKSDp (ORCPT ); Fri, 11 Dec 2015 13:03:45 -0500 MIME-Version: 1.0 In-Reply-To: <566A8C5B.7090209@redhat.com> References: <6b51dcc41f1b101f963945c5ec7093d72bdac429.1449702533.git.luto@kernel.org> <56694153.7020309@redhat.com> <20151211075249.GA12564@gmail.com> <566A8C5B.7090209@redhat.com> From: Andy Lutomirski Date: Fri, 11 Dec 2015 10:03:24 -0800 Message-ID: Subject: Re: [PATCH 2/5] x86, vdso, pvclock: Simplify and speed up the vdso pvclock reader To: Paolo Bonzini Cc: Ingo Molnar , Andy Lutomirski , X86 ML , Marcelo Tosatti , Radim Krcmar , "linux-kernel@vger.kernel.org" , kvm list , Alexander Graf Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1485 Lines: 37 On Fri, Dec 11, 2015 at 12:42 AM, Paolo Bonzini wrote: > > > On 11/12/2015 08:52, Ingo Molnar wrote: >> >> * Paolo Bonzini wrote: >>> >>> Reviewed-by: Paolo Bonzini >> >> Thanks. I've added your Reviewed-by to the 1/5 patch as well - to be able to put >> the whole series into the tip:x86/entry tree. Let me know if you'd like it to be >> done differently. > > The 1/5 patch is entirely in KVM and is not necessary for the rest of > the series to work. I would like it to be separate, because Marcelo has > not yet chimed in to say why it was necessary. > > Can you just apply patches 2-5? Yes, please. I don't grok the clock update mechanism in the KVM host well enough to be sure that patch 1 is actually correct. All I know is that it works better on my laptop with the patch than without the patch and that it seems at least conceptually correct. In any event, patch 1 is a host patch and 2-5 are guest patches, and they only interact to the extent that it's hard for me to test 2-5 on the guest without patch 1 on the host because without patch 1 my laptop's host kernel tends to disable stable kvmclock, thus disabling the entire mechanism in the guest. --Andy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/