Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752797AbbLKTJd (ORCPT ); Fri, 11 Dec 2015 14:09:33 -0500 Received: from mga01.intel.com ([192.55.52.88]:48964 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752552AbbLKTJb (ORCPT ); Fri, 11 Dec 2015 14:09:31 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,414,1444719600"; d="scan'208";a="705662962" Message-ID: <1449860966.2499.17.camel@loki> Subject: Re: [RFC PATCH] ASoC: dpcm: Apply symmetry for DPCM From: Liam Girdwood To: Koro Chen Cc: broonie@kernel.org, tiwai@suse.de, srv_heupstream@mediatek.com, linux-mediatek@lists.infradead.org, s.hauer@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, PC Liao Date: Fri, 11 Dec 2015 19:09:26 +0000 In-Reply-To: <1449804831-58929-1-git-send-email-koro.chen@mediatek.com> References: <1449804831-58929-1-git-send-email-koro.chen@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 998 Lines: 22 On Fri, 2015-12-11 at 11:33 +0800, Koro Chen wrote: > From: PC Liao > > DPCM does not fully support symmetry attributes. soc_pcm_apply_symmetry() > is skipped in soc_pcm_open() for DPCM, without being applied elsewhere. > So HW parameters cannot be correctly limited, and user space can do > playback/capture at different rates while HW actually does not support it. > soc_pcm_params_symmetry() will return error and the second stream stops. > > This patch adds soc_pcm_apply_symmetry() for FE, BE, and codec DAIs > in DPCM path that was skipped in soc_pcm_open(). > > Signed-off-by: PC Liao > Signed-off-by: Koro Chen Acked-by: Liam Girdwood -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/