Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754800AbbLKV3h (ORCPT ); Fri, 11 Dec 2015 16:29:37 -0500 Received: from mail-vk0-f52.google.com ([209.85.213.52]:33960 "EHLO mail-vk0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752952AbbLKV3f (ORCPT ); Fri, 11 Dec 2015 16:29:35 -0500 MIME-Version: 1.0 In-Reply-To: References: <1449771501-24976-1-git-send-email-geyslan@gmail.com> <20151211163019.GB9306@kroah.com> Date: Fri, 11 Dec 2015 18:29:34 -0300 Message-ID: Subject: Re: [PATCH v3 4/9] usb: host: ehci.h: fix single statement macros From: "Geyslan G. Bem" To: Greg Kroah-Hartman Cc: Peter Senna Tschudin , Alan Stern , linux-usb@vger.kernel.org, LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1408 Lines: 59 2015-12-11 17:55 GMT-03:00 Geyslan G. Bem : > 2015-12-11 13:30 GMT-03:00 Greg Kroah-Hartman : >> On Thu, Dec 10, 2015 at 03:18:19PM -0300, Geyslan G. Bem wrote: >>> Don't use the 'do {} while (0)' wrapper in a single statement macro. >>> >>> Caught by checkpatch: "WARNING: Single statement macros should not >>> use a do {} while (0) loop" >>> >>> Signed-off-by: Geyslan G. Bem >>> --- >>> Change in v3: >>> - There's no need to evaluate COUNT(x) in #ifdef EHCI_STATS >>> false branch. Thus an empty #define is the choice. >> >> Odd numbering scheme of patches, I can't figure this out... > Greg, > > I sent new versions only to modified ones. > 9 is v1. > 4 is v3. > rest is v2. > > Next time I'll send new versions for all. > >> >> Can you resend this whole series so I know I got it all correct? > I hope so. :-) Messing around with branches and merges here. I tell you soon. Greg, please, grab them. [PATCH resend 0/9] usb: host: ehci.h cleanup > >> >> thanks, >> >> greg k-h > > > > -- > Regards, > > Geyslan G. Bem > hackingbits.com -- Regards, Geyslan G. Bem hackingbits.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/