Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755064AbbLKX0S (ORCPT ); Fri, 11 Dec 2015 18:26:18 -0500 Received: from mx2.suse.de ([195.135.220.15]:40454 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753127AbbLKX0Q (ORCPT ); Fri, 11 Dec 2015 18:26:16 -0500 Date: Sat, 12 Dec 2015 00:26:11 +0100 (CET) From: Jiri Kosina X-X-Sender: jkosina@pobox.suse.cz To: Russell King - ARM Linux cc: Andrew Morton , Petr Mladek , Geert Uytterhoeven , Peter Zijlstra , Steven Rostedt , Daniel Thompson , Ingo Molnar , Thomas Gleixner , "linux-kernel@vger.kernel.org" , the arch/x86 maintainers , "linux-arm-kernel@lists.infradead.org" , "adi-buildroot-devel@lists.sourceforge.net" , Cris , Linux MIPS Mailing List , "linuxppc-dev@lists.ozlabs.org" , linux-s390 , Linux-sh list , sparclinux Subject: Re: [PATCH v3 4/4] printk/nmi: Increase the size of NMI buffer and make it configurable In-Reply-To: <20151211232113.GZ8644@n2100.arm.linux.org.uk> Message-ID: References: <1449667265-17525-1-git-send-email-pmladek@suse.com> <1449667265-17525-5-git-send-email-pmladek@suse.com> <20151211124159.GB3729@pathway.suse.cz> <20151211145725.b0e81bb4bb18fcd72ef5f557@linux-foundation.org> <20151211232113.GZ8644@n2100.arm.linux.org.uk> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 881 Lines: 24 On Fri, 11 Dec 2015, Russell King - ARM Linux wrote: > I'm personally happy with the existing code, and I've been wondering why > there's this effort to apply further cleanups - to me, the changelogs > don't seem to make that much sense, unless we want to start using > printk() extensively in NMI functions - using the generic nmi backtrace > code surely gets us something that works across all architectures... It is already being used extensively, and not only for all-CPU backtraces. For starters, please consider - WARN_ON(in_nmi()) - BUG_ON(in_nmi()) - anything being printed out from MCE handlers -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/