Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754298AbbLLBLA (ORCPT ); Fri, 11 Dec 2015 20:11:00 -0500 Received: from mail-pf0-f179.google.com ([209.85.192.179]:33889 "EHLO mail-pf0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753755AbbLLBK7 (ORCPT ); Fri, 11 Dec 2015 20:10:59 -0500 Date: Fri, 11 Dec 2015 17:10:56 -0800 From: Brian Norris To: Arnd Bergmann Cc: linux-mtd@lists.infradead.org, David Woodhouse , Roger Quadros , linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Tony Lindgren Subject: Re: [PATCH] mtd: omap_elm: print interrupt resource using %pr Message-ID: <20151212011056.GA144873@google.com> References: <2101351.RbJOfbsbGX@wuerfel> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2101351.RbJOfbsbGX@wuerfel> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1662 Lines: 41 Hi Arnd, On Tue, Dec 08, 2015 at 04:39:45PM +0100, Arnd Bergmann wrote: > When CONFIG_LPAE is set on ARM, resource_size_t is 64-bit wide > and we get a warning about an incorrect format string for printing > the interrupt number in elm_probe: > > drivers/mtd/nand/omap_elm.c: In function 'elm_probe': > drivers/mtd/nand/omap_elm.c:417:23: warning: format '%i' expects argument of type 'int', but argument 3 has type 'resource_size_t {aka long long unsigned int}' [-Wformat=] > > This patch avoids the type mismatch by printing the interrupt as > a resource using the %pr format string. > > Signed-off-by: Arnd Bergmann > --- > drivers/mtd/nand/omap_elm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/nand/omap_elm.c b/drivers/mtd/nand/omap_elm.c > index 235ec7992b4c..11f174b07217 100644 > --- a/drivers/mtd/nand/omap_elm.c > +++ b/drivers/mtd/nand/omap_elm.c > @@ -414,7 +414,7 @@ static int elm_probe(struct platform_device *pdev) > ret = devm_request_irq(&pdev->dev, irq->start, elm_isr, 0, > pdev->name, info); > if (ret) { > - dev_err(&pdev->dev, "failure requesting irq %i\n", irq->start); > + dev_err(&pdev->dev, "failure requesting %pr\n", &irq); drivers/mtd/nand/omap_elm.c:417 elm_probe() error: '%pr' expects argument of type struct resource *, but argument 3 has type 'struct resource**' [smatch] > return ret; > } > Brian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/