Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754563AbbLLBTV (ORCPT ); Fri, 11 Dec 2015 20:19:21 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:59211 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754172AbbLLBTU (ORCPT ); Fri, 11 Dec 2015 20:19:20 -0500 Date: Fri, 11 Dec 2015 20:19:16 -0500 (EST) Message-Id: <20151211.201916.1656429874143124778.davem@davemloft.net> To: eric.dumazet@gmail.com Cc: edumazet@google.com, marcelo.leitner@gmail.com, dvyukov@google.com, kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, vyasevich@gmail.com, nhorman@tuxdriver.com, linux-sctp@vger.kernel.org, syzkaller@googlegroups.com, kcc@google.com, glider@google.com, sasha.levin@oracle.com Subject: Re: [PATCH net] ipv6: sctp: clone options to avoid use after free From: David Miller In-Reply-To: <1449674706.9768.5.camel@edumazet-glaptop2.roam.corp.google.com> References: <20151209145917.GA3884@mrl.redhat.com> <1449674706.9768.5.camel@edumazet-glaptop2.roam.corp.google.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 11 Dec 2015 17:19:19 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 741 Lines: 22 From: Eric Dumazet Date: Wed, 09 Dec 2015 07:25:06 -0800 > From: Eric Dumazet > > SCTP is lacking proper np->opt cloning at accept() time. > > TCP and DCCP use ipv6_dup_options() helper, do the same > in SCTP. > > We might later factorize this code in a common helper to avoid > future mistakes. > > Reported-by: Dmitry Vyukov > Signed-off-by: Eric Dumazet Applied and queued up for -stable, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/