Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755315AbbLLCCY (ORCPT ); Fri, 11 Dec 2015 21:02:24 -0500 Received: from mail-vk0-f51.google.com ([209.85.213.51]:34952 "EHLO mail-vk0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754197AbbLLCCW (ORCPT ); Fri, 11 Dec 2015 21:02:22 -0500 MIME-Version: 1.0 In-Reply-To: <1449885021-25261-1-git-send-email-geyslan@gmail.com> References: <1449885021-25261-1-git-send-email-geyslan@gmail.com> Date: Fri, 11 Dec 2015 23:02:21 -0300 Message-ID: Subject: Re: [PATCH] usb: host: ehci-sched: silence checkpatch warning From: "Geyslan G. Bem" To: "Geyslan G. Bem" Cc: Joe Perches , Peter Senna Tschudin , Alan Stern , Greg Kroah-Hartman , linux-usb@vger.kernel.org, LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1762 Lines: 53 2015-12-11 22:50 GMT-03:00 Geyslan G. Bem : > This patch moves comment into the else branch avoiding the following > misleading warning. > > "braces {} are not necessary for single statement blocks" > > Caught by checkpatch. > > Signed-off-by: Geyslan G. Bem > Suggested-by: Joe Perches > --- > drivers/usb/host/ehci-sched.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/usb/host/ehci-sched.c b/drivers/usb/host/ehci-sched.c > index f6e828a..b2af0b3 100644 > --- a/drivers/usb/host/ehci-sched.c > +++ b/drivers/usb/host/ehci-sched.c > @@ -1560,13 +1560,10 @@ iso_stream_schedule( > (stream->ps.bw_period - 1); > stream->ps.phase_uf = start & 7; > reserve_release_iso_bandwidth(ehci, stream, 1); > - } > - > - /* New stream is already scheduled; use the upcoming slot */ > - else { > + } else { > + /* New stream is already scheduled; use the upcoming slot */ > start = (stream->ps.phase << 3) + stream->ps.phase_uf; > } > - > stream->next_uframe = start; > new_stream = true; > } > -- > 2.6.3 > This one must be applied only after the bunch [PATCH 00/10] usb: host: ehci-sched: cleanup https://lkml.org/lkml/2015/12/11/940 -- Regards, Geyslan G. Bem hackingbits.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/