Date: Fri, 11 Dec 2015 21:24:16 -0500
From: Sanidhya Solanki <jpage.lkml@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: lidza.louina@gmail.com, markh@compro.net, gregkh@linuxfoundation.org,
        driverdev-devel@linuxdriverproject.org, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: dgnc: Patch includes the checkpatch fixes
Message-ID: <20151211212416.6238df0d@gmail.com>
In-Reply-To: <20151211130233.GJ5284@mwanda>
References: <20151211032149.489d90d1@gmail.com>
	<20151211130233.GJ5284@mwanda>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1401
Lines: 33

On Fri, 11 Dec 2015 16:02:33 +0300
Dan Carpenter <dan.carpenter@oracle.com> wrote:

> On Fri, Dec 11, 2015 at 03:21:49AM -0500, Sanidhya Solanki wrote:
> > >From 1dbe78ce98037da5467d817a9db838d678b338ae Mon Sep 17 00:00:00 2001
> > From: Sanidhya Solanki <jpage.lkml@gmail.com>
> > Date: Fri, 11 Dec 2015 03:08:53 -0500
> > Subject: [PATCH] staging: dgnc: Patch includes the checkpatch fixes
> 
> 
> Don't include this stuff.
Whenever I remove that part, the "git am" command gives me an error that
it cannot detect patch format and the patch application fails.

Thanks for the macro information. I misunderstood initially and thought you 
wanted me to get rid of the entire code block included in the do-while, 
rather than just replacing the do-while loop with the code. I sent you 
an update patch that does just that and a separate patch that includes 
the TODO file update.

Any more errors in the code regarding parenthesis alignment are a 
checkpatch bug, which you can visually reconfirm.

Also, any more requests by checkpatch to further breakup the remaining
long lines may further degrade readablility due to presence of arrow
pointers.

Thanks
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/