Date: Sat, 12 Dec 2015 15:41:24 +0530
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: devel@driverdev.osuosl.org, kirk@reisers.ca, gregkh@linuxfoundation.org,
        speakup@linux-speakup.org, Saurabh Sengar <saurabh.truth@gmail.com>,
        linux-kernel@vger.kernel.org, samuel.thibault@ens-lyon.org,
        chris@the-brannons.com
Subject: Re: [PATCH] Staging: speakup: varhandlers: cleanup of function
 spk_get_punc_var
Message-ID: <20151212101124.GB13516@sudip-pc>
References: <1449493511-14410-1-git-send-email-saurabh.truth@gmail.com>
 <20151209051718.GA4159@sudip-pc>
 <20151212084025.GN5284@mwanda>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20151212084025.GN5284@mwanda>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1199
Lines: 27

On Sat, Dec 12, 2015 at 11:40:25AM +0300, Dan Carpenter wrote:
> On Wed, Dec 09, 2015 at 10:47:18AM +0530, Sudip Mukherjee wrote:
> > On Mon, Dec 07, 2015 at 06:35:11PM +0530, Saurabh Sengar wrote:
> > > This patch does the following:
> > > * changed the complicated if statements to simple case statements
> > > * in case of E_DEFAULT, no need to return error as ERESTART,
> > > because this is the user asked for. Hence function should return success.
> > > * ret variable is 0 always, hence removed it.
> > > * removed one ternary operator, as it was always returning the status value only,
> > > and hence removed the status variable too
> > 
> > That becomes 4 different changes. Please break them into separate
> > patches.
> 
> It's cleaning up one function so you could argue that it's just one
> thing.

Then maybe that should have been mentioned in the commit message along
with mentioning point wise the different changes made.

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/