Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752371AbbLLL6j (ORCPT ); Sat, 12 Dec 2015 06:58:39 -0500 Received: from mail-ig0-f174.google.com ([209.85.213.174]:33336 "EHLO mail-ig0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751172AbbLLL6i (ORCPT ); Sat, 12 Dec 2015 06:58:38 -0500 MIME-Version: 1.0 In-Reply-To: <20151212101124.GB13516@sudip-pc> References: <1449493511-14410-1-git-send-email-saurabh.truth@gmail.com> <20151209051718.GA4159@sudip-pc> <20151212084025.GN5284@mwanda> <20151212101124.GB13516@sudip-pc> Date: Sat, 12 Dec 2015 17:28:37 +0530 Message-ID: Subject: Re: [PATCH] Staging: speakup: varhandlers: cleanup of function spk_get_punc_var From: Saurabh Sengar To: Sudip Mukherjee Cc: Dan Carpenter , devel@driverdev.osuosl.org, kirk@reisers.ca, Greg KH , speakup@linux-speakup.org, linux-kernel@vger.kernel.org, Samuel Thibault , Christopher Brannon Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1402 Lines: 34 On 12 December 2015 at 15:41, Sudip Mukherjee wrote: > On Sat, Dec 12, 2015 at 11:40:25AM +0300, Dan Carpenter wrote: >> On Wed, Dec 09, 2015 at 10:47:18AM +0530, Sudip Mukherjee wrote: >> > On Mon, Dec 07, 2015 at 06:35:11PM +0530, Saurabh Sengar wrote: >> > > This patch does the following: >> > > * changed the complicated if statements to simple case statements >> > > * in case of E_DEFAULT, no need to return error as ERESTART, >> > > because this is the user asked for. Hence function should return success. >> > > * ret variable is 0 always, hence removed it. >> > > * removed one ternary operator, as it was always returning the status value only, >> > > and hence removed the status variable too >> > >> > That becomes 4 different changes. Please break them into separate >> > patches. >> >> It's cleaning up one function so you could argue that it's just one >> thing. > > Then maybe that should have been mentioned in the commit message along > with mentioning point wise the different changes made. > That is already mentioned in subject line of patch, which will be the part of commit message. Regrads, Saurabh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/