Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752687AbbLLNDJ (ORCPT ); Sat, 12 Dec 2015 08:03:09 -0500 Received: from mail-wm0-f54.google.com ([74.125.82.54]:36763 "EHLO mail-wm0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751496AbbLLNDF convert rfc822-to-8bit (ORCPT ); Sat, 12 Dec 2015 08:03:05 -0500 Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 9.2 \(3112\)) Subject: Re: [PATCH] drivers:pci:host Fix missing line after declarations From: sasa bogicevic In-Reply-To: <20151212132316.27e10a6d@free-electrons.com> Date: Sat, 12 Dec 2015 14:03:01 +0100 Cc: bhelgaas@google.com, Richard.Zhu@freescale.com, l.stach@penguintronix.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8BIT Message-Id: References: <1449920508-105873-1-git-send-email-brutallesale@gmail.com> <20151212132316.27e10a6d@free-electrons.com> To: Thomas Petazzoni X-Mailer: Apple Mail (2.3112) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1473 Lines: 48 Hi Thomas, I just went with checkpatch.pl approach I hope this patch didn’t ruin your day :) { name: Bogicevic Sasa phone: +381606006200 } > On Dec 12, 2015, at 13:23, Thomas Petazzoni wrote: > > Dear Bogicevic Sasa, > > On Sat, 12 Dec 2015 03:41:48 -0800, Bogicevic Sasa wrote: >> This fixes few warnings about missing line after declarations and one >> no whitespace is necesarry before that "(" >> >> Signed-off-by: Bogicevic Sasa > > I am not a big fan of this struct rule that insists in having an empty > line after declarations, I believe when a for() loop or if() condition > has only one line of declaration and one line of useful code, it > doesn't make much sense. But oh well, that's the rule, so let's do it > this way. > >> --- >> drivers/pci/host/pci-imx6.c | 2 +- >> drivers/pci/host/pci-mvebu.c | 3 +++ >> drivers/pci/host/pcie-rcar.c | 2 ++ >> 3 files changed, 6 insertions(+), 1 deletion(-) > > For the pci-mvebu.c part: > > Reviewed-by: Thomas Petazzoni > > Thomas > -- > Thomas Petazzoni, CTO, Free Electrons > Embedded Linux, Kernel and Android engineering > http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/