Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752567AbbLLNRG (ORCPT ); Sat, 12 Dec 2015 08:17:06 -0500 Received: from proxima.lp0.eu ([81.2.80.65]:51065 "EHLO proxima.lp0.eu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751300AbbLLNRD (ORCPT ); Sat, 12 Dec 2015 08:17:03 -0500 Subject: Re: [PATCH linux-next (v3) 1/3] MIPS: bcm963xx: Add Broadcom BCM963xx board nvram data structure To: Jonas Gorski References: <566B460F.1040603@simon.arlott.org.uk> <566B4D34.9040707@simon.arlott.org.uk> Cc: David Woodhouse , Brian Norris , Florian Fainelli , Ralf Baechle , Kevin Cernekee , Linux Kernel Mailing List , MTD Maling List , bcm-kernel-feedback-list , MIPS Mailing List , linux-api@vger.kernel.org From: Simon Arlott Message-ID: <566C1E44.3010506@simon.arlott.org.uk> Date: Sat, 12 Dec 2015 13:16:52 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1975 Lines: 47 On 11/12/15 23:29, Jonas Gorski wrote: > On Fri, Dec 11, 2015 at 11:24 PM, Simon Arlott wrote: >> On 11/12/15 22:02, Jonas Gorski wrote: >>> On Fri, Dec 11, 2015 at 10:54 PM, Simon Arlott wrote: >>>> Broadcom BCM963xx boards have multiple nvram variants across different >>>> SoCs with additional checksum fields added whenever the size of the >>>> nvram was extended. >>>> >>>> Add this structure as a header file so that multiple drivers and userspace >>>> can use it. >>>> >>>> Signed-off-by: Simon Arlott >>>> --- >>>> v3: Fix includes/type names, add comments explaining the nvram struct. >>>> >>>> v2: Use external struct bcm963xx_nvram definition for bcm963268part. ... >>>> diff --git a/include/uapi/linux/bcm963xx_nvram.h b/include/uapi/linux/bcm963xx_nvram.h >>>> new file mode 100644 >>>> index 0000000..2dcb307 >>>> --- /dev/null >>>> +++ b/include/uapi/linux/bcm963xx_nvram.h >>> >>> Why uapi? The nvram layout isn't really enforced to be that way, and >>> at least Huawei uses a modified one on some devices (in case you >>> wondered why bcm63xx doesn't fail a crc32-"broken" one), so IMHO it >>> should be kept for in-kernel use only. >> >> Because Florian suggested include/uapi/linux/bcm963xx_nvram.h; I could >> move it to include/linux/ instead if this is preferred. ... >>>> + * Do not use the __reserved fields, especially not as an offset for CRC >>>> + * calculations (use BCM963XX_NVRAM_*_SIZE instead). These may be removed or >>>> + * repositioned. > > Because I just saw that: Nobody will read that. ;p I'll move this to include/linux/bcm963xx_nvram.h and omit the linux-api mailing list when I next send the patch series. -- Simon Arlott -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/