Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752778AbbLLOlq (ORCPT ); Sat, 12 Dec 2015 09:41:46 -0500 Received: from mout.web.de ([212.227.17.12]:58074 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750814AbbLLOlo (ORCPT ); Sat, 12 Dec 2015 09:41:44 -0500 Subject: [PATCH 4/7] iscsi-target: Make a variable initialisation a bit more obvious in iscsi_create_default_params() To: linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, "Nicholas A. Bellinger" References: <566ABCD9.1060404@users.sourceforge.net> <566C2F7B.6030704@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Message-ID: <566C3225.4070100@users.sourceforge.net> Date: Sat, 12 Dec 2015 15:41:41 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <566C2F7B.6030704@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:BHpSDuUb3+I4VRXB2jypY6eTgy5c0ZKYjHEFOBqpv2WAXE3Rzrz owMvBdLH/SUx4VGzq3hQ9G5zwd9w1ml3Taz0XBmAgwMFTpQkBJzSPyNyiZKpgQqhc2ZRJ8Y z7SqOxm7P33GOEIvh7QcW0ntajdX6xp6vFeXqezcdBUVMaIIyZN+uawphqOBTe2ZarFr0HI taKee0em2n9+XNRmYnaLQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:RI6VCZpmeWM=:lRXWYppe1NQHjh+ziKShB6 j8eXhiFMQfcOxce/MNHJ5voNwc91a4hi7DiNNTYp1HKwYwijk1EOaF+uIDBXy7YXdclc8XLgj adpsjG9ti2xU07MEQkwP4I7wVy6qLso9ZsTz62/K5N4R4Wbt7jZuQLnAua0fZVgEcCpZm9MAN Ttak3hMABbpn4ZzAo5vu6jgReiWQrGU0Wsqa0kLEgl1Lhf/K9LKCnUVgrHM1Y26dMtT4Q/XVy KK2W/YbS0nmgYCagYmJuNF18Fue2Sj1GliAdCGclB9bgZqr8F2JqtzrR7arlFT9vr9Fb2mXyI +Bqwnsejpm6eW0EGa7+73q8+Th6Te1iDLEwYCk5C8o9ZzPGDsNOEH/xWti4xRhOYqGg6xWv1i Ad8iKr8KpLUQJKDX3DSqTwwq+PeeTKbtWNnFSZetrw/ITNvNujJwwJePePosbKGqFl1yh0of3 kOjTcq6VrGicwg1Z8p+N0q9w/wZOPG6l2admZUZ18FbSJRQf0BDEN0JTtsOcwhA6yn3cM414r FK53EnANhm0hu4HbAF4Ez4w2ZeRYmbQaeILYyNf/OWBH8ruZ5oQlwGwhMCvvPlfUlR6IEAvES JnUXxrLobyScKKafh9P+/FmcjLiNSlyg6tbYhCNjSz/fKQD7CBYoMuFebzc1gJxF6JtA/uJuA v2UDkA27fDbDxm6n3xrTh3vivmeIXZvIdhdkGZLiQztQeDsKWSlVCyIMb+aIC+EoMu27B3I3M nlXlyF5yV2+Qavl3SKyn+5288yVetEwrR6R50vl4wzwtN/yMBnb8pFf8BIpctqM/W5vUBA6Q6 F0KnD01 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1479 Lines: 40 From: Markus Elfring Date: Sat, 12 Dec 2015 13:44:06 +0100 The variable "pl" was declared and immediately assigned a return value from a function call in a separate statement. * Let us express the desired variable initialisation directly. * Avoid the repetition of the data type specification for the involved memory allocation according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/target/iscsi/iscsi_target_parameters.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/target/iscsi/iscsi_target_parameters.c b/drivers/target/iscsi/iscsi_target_parameters.c index e0b173d..3f3842f 100644 --- a/drivers/target/iscsi/iscsi_target_parameters.c +++ b/drivers/target/iscsi/iscsi_target_parameters.c @@ -200,9 +200,8 @@ free_param: int iscsi_create_default_params(struct iscsi_param_list **param_list_ptr) { struct iscsi_param *param; - struct iscsi_param_list *pl; + struct iscsi_param_list *pl = kzalloc(sizeof(*pl), GFP_KERNEL); - pl = kzalloc(sizeof(struct iscsi_param_list), GFP_KERNEL); if (!pl) { pr_err("Unable to allocate memory for" " struct iscsi_param_list.\n"); -- 2.6.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/