Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751608AbbLLPso (ORCPT ); Sat, 12 Dec 2015 10:48:44 -0500 Received: from mail-vk0-f53.google.com ([209.85.213.53]:34551 "EHLO mail-vk0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751032AbbLLPsn (ORCPT ); Sat, 12 Dec 2015 10:48:43 -0500 MIME-Version: 1.0 In-Reply-To: <566C3431.1090808@cogentembedded.com> References: <1449883170-21225-1-git-send-email-geyslan@gmail.com> <1449883170-21225-11-git-send-email-geyslan@gmail.com> <566C3431.1090808@cogentembedded.com> Date: Sat, 12 Dec 2015 12:48:42 -0300 Message-ID: Subject: Re: [PATCH 10/10] usb: host: ehci-sched: remove unnecessary braces From: "Geyslan G. Bem" To: Sergei Shtylyov Cc: Peter Senna Tschudin , linux-usb@vger.kernel.org, LKML , Alan Stern , Greg Kroah-Hartman Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1740 Lines: 60 2015-12-12 11:50 GMT-03:00 Sergei Shtylyov : > On 12/12/2015 4:19 AM, Geyslan G. Bem wrote: > >> This patch removes unnecessary braces in single statement blocks at the >> same time as replaces the if statement with a ternary conditional. >> >> Tested by compilation only. >> Caught by checkpatch. >> >> Signed-off-by: Geyslan G. Bem >> --- >> drivers/usb/host/ehci-sched.c | 6 +----- >> 1 file changed, 1 insertion(+), 5 deletions(-) >> >> diff --git a/drivers/usb/host/ehci-sched.c b/drivers/usb/host/ehci-sched.c >> index 1dc1d5c..f6e828a 100644 >> --- a/drivers/usb/host/ehci-sched.c >> +++ b/drivers/usb/host/ehci-sched.c >> @@ -1060,11 +1060,7 @@ iso_stream_init( >> epnum = usb_pipeendpoint(urb->pipe); >> is_input = usb_pipein(urb->pipe) ? USB_DIR_IN : 0; >> maxp = usb_endpoint_maxp(&urb->ep->desc); >> - if (is_input) { >> - buf1 = (1 << 11); >> - } else { >> - buf1 = 0; >> - } >> + buf1 = (is_input) ? (1 << 11) : 0; > > > Parens not needed, especially the first ones. Right. Removing them. After changing those patches should I resend the whole bunch with v2 tag, or only the changed ones? And about a sequential patch that I sent for the same file, is it better leave it out or add it to the bunch? [PATCH] usb: host: ehci-sched: silence checkpatch warning Tks. > > [...] > > MBR, Sergei > -- Regards, Geyslan G. Bem hackingbits.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/