Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752486AbbLLRSD (ORCPT ); Sat, 12 Dec 2015 12:18:03 -0500 Received: from mx01-fr.bfs.de ([193.174.231.67]:57162 "EHLO mx01-fr.bfs.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752073AbbLLRSA (ORCPT ); Sat, 12 Dec 2015 12:18:00 -0500 Message-ID: <566C56BA.7010903@bfs.de> Date: Sat, 12 Dec 2015 18:17:46 +0100 From: walter harms Reply-To: wharms@bfs.de User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; de; rv:1.9.1.16) Gecko/20101125 SUSE/3.0.11 Thunderbird/3.0.11 MIME-Version: 1.0 To: SF Markus Elfring CC: linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, "Nicholas A. Bellinger" , LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: Re: [PATCH 7/7] iscsi-target: Make two variable initialisations a bit more obvious in iscsi_check_valuelist_for_support() References: <566ABCD9.1060404@users.sourceforge.net> <566C2F7B.6030704@users.sourceforge.net> <566C3304.1090802@users.sourceforge.net> In-Reply-To: <566C3304.1090802@users.sourceforge.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1573 Lines: 49 Am 12.12.2015 15:45, schrieb SF Markus Elfring: > From: Markus Elfring > Date: Sat, 12 Dec 2015 15:04:57 +0100 > > The variable "acceptor_values" and "proposer_values" were initialized > by null pointers and immediately assigned values from input parameters > by separate statements. > Let us express the desired variable initialisations directly. > > Signed-off-by: Markus Elfring > --- > drivers/target/iscsi/iscsi_target_parameters.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/target/iscsi/iscsi_target_parameters.c b/drivers/target/iscsi/iscsi_target_parameters.c > index 53e3345..fb6fd34 100644 > --- a/drivers/target/iscsi/iscsi_target_parameters.c > +++ b/drivers/target/iscsi/iscsi_target_parameters.c > @@ -921,10 +921,7 @@ static char *iscsi_check_valuelist_for_support( > char *value) > { > char *tmp1, *tmp2; > - char *acceptor_values = NULL, *proposer_values = NULL; > - > - acceptor_values = param->value; > - proposer_values = value; > + char *acceptor_values = param->value, *proposer_values = value; > I do not thing that this is a good idea, i find the first version more readable but you are right the NULL can be removed. just my 2 cents, re, wh > do { > if (!proposer_values) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/