Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752505AbbLLVaf (ORCPT ); Sat, 12 Dec 2015 16:30:35 -0500 Received: from mail5.windriver.com ([192.103.53.11]:37540 "EHLO mail5.wrs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751640AbbLLVae (ORCPT ); Sat, 12 Dec 2015 16:30:34 -0500 From: Paul Gortmaker To: CC: Paul Gortmaker , Eric Paris Subject: [PATCH 01/10] fs: make notify dnotify.c explicitly non-modular Date: Sat, 12 Dec 2015 16:30:03 -0500 Message-ID: <1449955812-10149-2-git-send-email-paul.gortmaker@windriver.com> X-Mailer: git-send-email 2.6.1 In-Reply-To: <1449955812-10149-1-git-send-email-paul.gortmaker@windriver.com> References: <1449955812-10149-1-git-send-email-paul.gortmaker@windriver.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1653 Lines: 50 The Kconfig currently controlling compilation of this code is: config DNOTIFY bool "Dnotify support" ...meaning that it currently is not being built as a module by anyone. Lets remove the couple traces of modularity so that when reading the code there is no doubt it is builtin-only. Since module_init translates to device_initcall in the non-modular case, the init ordering gets bumped to one level earlier when we use the more appropriate fs_initcall here. However we've made similar changes before without any fallout and none is expected here either. We don't replace module.h with init.h since the file already has that. Cc: Eric Paris Signed-off-by: Paul Gortmaker --- fs/notify/dnotify/dnotify.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/fs/notify/dnotify/dnotify.c b/fs/notify/dnotify/dnotify.c index 6faaf710e563..f67c82e72617 100644 --- a/fs/notify/dnotify/dnotify.c +++ b/fs/notify/dnotify/dnotify.c @@ -17,7 +17,6 @@ * General Public License for more details. */ #include -#include #include #include #include @@ -390,5 +389,4 @@ static int __init dnotify_init(void) panic("unable to allocate fsnotify group for dnotify\n"); return 0; } - -module_init(dnotify_init) +fs_initcall(dnotify_init) -- 2.6.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/