Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752591AbbLLVuF (ORCPT ); Sat, 12 Dec 2015 16:50:05 -0500 Received: from mail-pf0-f178.google.com ([209.85.192.178]:32910 "EHLO mail-pf0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751199AbbLLVuC (ORCPT ); Sat, 12 Dec 2015 16:50:02 -0500 From: Peter Hurley To: Greg Kroah-Hartman , Jiri Slaby Cc: linux-kernel@vger.kernel.org, Peter Hurley Subject: [PATCH 0/3] Remove ASYNC_CLOSING Date: Sat, 12 Dec 2015 13:49:33 -0800 Message-Id: <1449956976-4784-1-git-send-email-peter@hurleysoftware.com> X-Mailer: git-send-email 2.6.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1663 Lines: 45 Hi Greg, This series removes ASYNC_CLOSING from kernel use. However, the definition is in a uapi header so I think it needs to stay. The mxser driver used ASYNC_CLOSING to purge its fifo _with each byte received_ while closing. This is clearly unnecessary but the hangup/shutdown sequence in that driver is spaghetti and I don't have the hardware to test (what I would consider to be) the proper fix: cleaning up its hangup/shutdown so that clearing the fifo can be done once in shutdown. The isdn subsystem used ASYNC_CLOSING for unclear purposes; the immediate effect was to prevent sending AT commands from the emulator, but its not clear why that's necessary when closing. Since idsn does not use the tty_port helpers, I simply added to isdn the equivalent of an ASYNC_CLOSING flag. Regards, Peter Hurley (3): tty: mxser: Remove ASYNC_CLOSING isdn: Remove ASYNC_CLOSING tty: Remove ASYNC_CLOSING drivers/isdn/i4l/isdn_tty.c | 12 ++++++------ drivers/s390/char/con3215.c | 3 +-- drivers/tty/mxser.c | 9 +++++---- drivers/tty/rocket.c | 2 +- drivers/tty/serial/68328serial.c | 3 +-- drivers/tty/serial/crisv10.c | 3 +-- drivers/tty/serial/serial_core.c | 1 - drivers/tty/tty_port.c | 3 +-- include/linux/isdn.h | 1 + net/irda/ircomm/ircomm_tty.c | 4 ---- 10 files changed, 17 insertions(+), 24 deletions(-) -- 2.6.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/