Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751804AbbLMKdl (ORCPT ); Sun, 13 Dec 2015 05:33:41 -0500 Received: from down.free-electrons.com ([37.187.137.238]:56284 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751523AbbLMKdj (ORCPT ); Sun, 13 Dec 2015 05:33:39 -0500 Date: Sun, 13 Dec 2015 11:33:29 +0100 From: Thomas Petazzoni To: Paul Gortmaker Cc: , Jason Cooper , Bjorn Helgaas , , Subject: Re: [PATCH 03/10] drivers/pci: make host/pci-mvebu.c explicitly non-modular Message-ID: <20151213113329.3b1a303f@free-electrons.com> In-Reply-To: <1449970917-12633-4-git-send-email-paul.gortmaker@windriver.com> References: <1449970917-12633-1-git-send-email-paul.gortmaker@windriver.com> <1449970917-12633-4-git-send-email-paul.gortmaker@windriver.com> Organization: Free Electrons X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2034 Lines: 54 Paul, On Sat, 12 Dec 2015 20:41:50 -0500, Paul Gortmaker wrote: > The Kconfig currently controlling compilation of this code is: > > drivers/pci/host/Kconfig:config PCI_MVEBU > drivers/pci/host/Kconfig: bool "Marvell EBU PCIe controller" > > ...meaning that it currently is not being built as a module by anyone. > > Lets remove the modular code that is essentially orphaned, so that > when reading the driver there is no doubt it is builtin-only. > > Since module_platform_driver() uses the same init level priority as > builtin_platform_driver() the init ordering remains unchanged with > this commit. > > We don't have to disallow a driver unbind, since that is already > done for us in this driver. > > Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. > > We also delete the MODULE_LICENSE tag etc. since all that information > was (or is now ) contained at the top of the file in the comments. > > Cc: Thomas Petazzoni > Cc: Jason Cooper > Cc: Bjorn Helgaas > Cc: linux-pci@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Signed-off-by: Paul Gortmaker > --- > drivers/pci/host/pci-mvebu.c | 11 ++++------- > 1 file changed, 4 insertions(+), 7 deletions(-) I think the general direction should rather be to change the PCI subsystem to make it possible for those drivers to be built as modules. However, since this is quite certainly a much larger effort, there is no reason to not clean things up as they are today, so: Reviewed-by: Thomas Petazzoni Thanks, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/