Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752018AbbLMP4a (ORCPT ); Sun, 13 Dec 2015 10:56:30 -0500 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:34922 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751884AbbLMP42 (ORCPT ); Sun, 13 Dec 2015 10:56:28 -0500 Date: Sun, 13 Dec 2015 10:55:54 -0500 From: Chris Mason To: Peter Zijlstra CC: Linus Torvalds , Dave Jones , LKML , Jon Christopherson , NeilBrown , Ingo Molnar , David Howells , Steven Whitehouse Subject: Re: [PATCH] lock_page() doesn't lock if __wait_on_bit_lock returns -EINTR Message-ID: <20151213155554.GA2733@ret.masoncoding.com> Mail-Followup-To: Chris Mason , Peter Zijlstra , Linus Torvalds , Dave Jones , LKML , Jon Christopherson , NeilBrown , Ingo Molnar , David Howells , Steven Whitehouse References: <20151212162342.GF11257@ret.masoncoding.com> <20151213095001.GI6357@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20151213095001.GI6357@twins.programming.kicks-ass.net> User-Agent: Mutt/1.5.23.1 (2014-03-12) X-Originating-IP: [192.168.52.123] X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2015-12-13_12:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 788 Lines: 18 On Sun, Dec 13, 2015 at 10:50:01AM +0100, Peter Zijlstra wrote: > On Sat, Dec 12, 2015 at 11:41:26AM -0800, Linus Torvalds wrote: > > It looks like PeterZ's pending patch should fix this, by passing in > > the proper TASK_UNINTERRUPTIBLE to the bit_wait_io function, and going > > back to signal_pending_state(). PeterZ, did I follow the history of > > this correctly? > > Yes. I made a right mess of things with my 'fix'. Our two fixes together made it overnight. So at least for the lock_page() case things are extra super fixed. -chris -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/