Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752252AbbLMSPW (ORCPT ); Sun, 13 Dec 2015 13:15:22 -0500 Received: from mail-wm0-f49.google.com ([74.125.82.49]:35828 "EHLO mail-wm0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751145AbbLMSPU convert rfc822-to-8bit (ORCPT ); Sun, 13 Dec 2015 13:15:20 -0500 From: Nicolai Stange To: Frederik Cc: Greg KH , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, jslaby@suse.com, linux-kernel@i4.cs.fau.de, lukas.braun@fau.de Subject: Re: [PATCH 0/9] Fix checkpatch errors References: <1449830170-15096-1-git-send-email-frederik.voelkel@fau.de> <20151213070622.GA13621@kroah.com> <20151213174429.GB11792@faumail.uni-erlangen.de> Date: Sun, 13 Dec 2015 19:15:16 +0100 In-Reply-To: <20151213174429.GB11792@faumail.uni-erlangen.de> (Frederik's message of "Sun, 13 Dec 2015 18:44:30 +0100") Message-ID: <87poyamczv.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1391 Lines: 38 Frederik writes: > On Sat, 12. Dec 23:06, Greg KH wrote: >> On Fri, Dec 11, 2015 at 11:36:00AM +0100, Frederik Völkel wrote: >> > This patch series fixes all checkpatch error in 68328serial.c except >> > 5 trailing whitespace errors we are unsure how to fix. >> >> What are the errors you are not sure how to fix? >> >> thanks, >> >> greg k-h > > All 5 errors are at comments. It is not clear to us where exactly the > trailing whitespace is checkpatch complains(lines 271, 770, 889, 993 > and 1040). W/o your series applied (so line numbering might be slightly different), checkpatch.pl says: ERROR: trailing whitespace #270: FILE: -:270: +^I * This do { } while() loop will get ALL chars out of Rx FIFO $ AFAICS, your patch [7/9] ("drivers: tty: 68328serial.c: remove trailing whitespaces") doesn't fix this one. In good old regexp tradition, the '$' sign denotes the end of line. So, there is a single space after "FIFO" and before the end of line. If you happen to be Emacs users, consider trying out whitespace-mode. If not, try to find another way to make your editor visualize whitespace somehow. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/